Permalink
Browse files

Event: Trigger checkbox and radio click events identically

Fixes gh-3423
Closes gh-3494
  • Loading branch information...
alexr101 authored and gibson042 committed Jan 11, 2017
1 parent 3c89329 commit b442abacbb8464f0165059e8da734e3143d0721f
Showing with 10 additions and 8 deletions.
  1. +6 −4 src/event.js
  2. +3 −3 src/manipulation.js
  3. +1 −1 src/serialize.js
  4. 0 src/{manipulation → }/var/rcheckableType.js
View
@@ -3,12 +3,12 @@ define( [
"./var/document",
"./var/documentElement",
"./var/rnothtmlwhite",
"./var/rcheckableType",
"./var/slice",
"./data/var/dataPriv",
"./core/init",
"./selector"
], function( jQuery, document, documentElement, rnothtmlwhite, slice, dataPriv ) {
], function( jQuery, document, documentElement, rnothtmlwhite, rcheckableType, slice, dataPriv ) {
"use strict";
@@ -474,9 +474,11 @@ jQuery.event = {
},
click: {
// For checkbox, fire native event so checked state will be right
// For checkable types, fire native event so checked state will be right
trigger: function() {
if ( this.type === "checkbox" && this.click && jQuery.nodeName( this, "input" ) ) {
if ( rcheckableType.test( this.type ) &&
this.click && jQuery.nodeName( this, "input" ) ) {
this.click();
return false;
}
View
@@ -2,8 +2,8 @@ define( [
"./core",
"./var/concat",
"./var/push",
"./var/rcheckableType",
"./core/access",
"./manipulation/var/rcheckableType",
"./manipulation/var/rtagName",
"./manipulation/var/rscriptType",
"./manipulation/wrapMap",
@@ -21,8 +21,8 @@ define( [
"./traversing",
"./selector",
"./event"
], function( jQuery, concat, push, access,
rcheckableType, rtagName, rscriptType,
], function( jQuery, concat, push, rcheckableType,
access, rtagName, rscriptType,
wrapMap, getAll, setGlobalEval, buildFragment, support,
dataPriv, dataUser, acceptData, DOMEval ) {
View
@@ -1,6 +1,6 @@
define( [
"./core",
"./manipulation/var/rcheckableType",
"./var/rcheckableType",
"./core/init",
"./traversing", // filter
"./attributes/prop"
File renamed without changes.

0 comments on commit b442aba

Please sign in to comment.