Skip to content
Permalink
Browse files

We don't do end of line comments, move them above.

  • Loading branch information...
jeresig committed Nov 9, 2010
1 parent a4df694 commit b5b3c73db3e4e615e504cd0af08ff6842b104542
Showing with 5 additions and 3 deletions.
  1. +3 −2 src/event.js
  2. +2 −1 src/manipulation.js
@@ -33,7 +33,7 @@ jQuery.event = {
if ( handler === false ) {
handler = returnFalse;
} else if ( !handler ) {
// Fixes bug #7229. Fix recommended by jdalton
// Fixes bug #7229. Fix recommended by jdalton
return;
}

@@ -490,7 +490,8 @@ jQuery.event = {

// Fix target property, if necessary
if ( !event.target ) {
event.target = event.srcElement || document; // Fixes #1925 where srcElement might not be defined either
// Fixes #1925 where srcElement might not be defined either
event.target = event.srcElement || document;
}

// check if target is a textnode (safari)
@@ -7,7 +7,8 @@ var rinlinejQuery = / jQuery\d+="(?:\d+|null)"/g,
rtbody = /<tbody/i,
rhtml = /<|&#?\w+;/,
rnocache = /<(?:script|object|embed|option|style)/i,
rchecked = /checked\s*(?:[^=]|=\s*.checked.)/i, // checked="checked" or checked (html5)
// checked="checked" or checked (html5)

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Nov 9, 2010

Contributor

FYI, the shorthand notation for boolean attributes, e.g. <input checked> is just HTML (not new in HTML5 or anything). You may want to remove the 5.

This comment has been minimized.

Copy link
@leeoniya

leeoniya Nov 9, 2010

just "checked" with no value is HTML4, and i believe is XHTML invalid. maybe it was a typo?

This comment has been minimized.

Copy link
@mathiasbynens

mathiasbynens Nov 9, 2010

Contributor

Of course it’s invalid XHTML — good point, leeoniya — but still; this is just an HTML feature, not a new HTML5 thing.

This comment has been minimized.

Copy link
@leeoniya

leeoniya Nov 9, 2010

it should read (<=html4), or nothing. but certainly not html5 :)

rchecked = /checked\s*(?:[^=]|=\s*.checked.)/i,
raction = /\=([^="'>\s]+\/)>/g,
wrapMap = {
option: [ 1, "<select multiple='multiple'>", "</select>" ],

0 comments on commit b5b3c73

Please sign in to comment.
You can’t perform that action at this time.