Skip to content
Browse files
Fix Makefile to use plain sed agin. Remove unicode trickery. Thanks t…
…o danheberden and gnarf for figuring out why it previously faild on Mac OS X.
  • Loading branch information
jitter committed Jan 26, 2011
1 parent 6344821 commit ba43d37
Showing 1 changed file with 1 addition and 2 deletions.
@@ -106,8 +106,7 @@ ${JQ_MIN}: jquery
@@if test ! -z ${JS_ENGINE}; then \
echo "Minifying jQuery" ${JQ_MIN}; \
${COMPILER} ${JQ} > ${JQ_MIN}.tmp; \
echo ";" >> ${JQ_MIN}.tmp; \
sed 's/\*\/(/*\/ʩ(/' ${JQ_MIN}.tmp | tr "ʩ" "\n" > ${JQ_MIN}; \
sed '$ s#^\( \*/\)\(.\+\)#\1\n\2;#' ${JQ_MIN}.tmp > ${JQ_MIN}; \
rm -rf ${JQ_MIN}.tmp; \
else \
echo "You must have NodeJS installed in order to minify jQuery."; \

1 comment on commit ba43d37

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this commit, on Mac OS X 10.6.6, the semicolon at the end of the file is now missing. The newline between the copyright comment and the minified code is also missing. I believe it's due to further portability issues with sed. I've added a pull request with a commit to fix this here: #214

Please sign in to comment.