Note that I will be adding some code to strip these function wrappers off during the build process so that the final jquery.js will be smaller in size.
During the build process, you're going to remove the surrounding closure from core.js as well, so that jquery.js is smaller in size, and actually works when noConflict( true ) is called, right? (just double-checking)
@jdalton: The vast majority of the shared private variables were removed back in March - some additional tinkering will need to be done to tackle the remaining few but it shouldn't be bad. I'm actually working on it right now.
Woot! I should probably look into this for FuseJS too. I currently share a lot of variables between modules and rely on a custom build process like MooTools to keep the primary closure. I feel like singing a little Boys II Men for the memory of the private variables awesomeness :{D
@helianthus: Actually already fixed it - but just noticed that it was in a separate branch. You can see it over here: a166860 (it will be merged into the main branch very soon)
This comment has been minimized.
jeresig repliedSep 8, 2010
Note that I will be adding some code to strip these function wrappers off during the build process so that the final jquery.js will be smaller in size.
This comment has been minimized.
cowboy repliedSep 8, 2010
During the build process, you're going to remove the surrounding closure from core.js as well, so that jquery.js is smaller in size, and actually works when
noConflict( true )
is called, right? (just double-checking)This comment has been minimized.
jdalton repliedSep 8, 2010
How does this work with shared private variables across modules ?
This comment has been minimized.
jeresig repliedSep 8, 2010
@jdalton: The vast majority of the shared private variables were removed back in March - some additional tinkering will need to be done to tackle the remaining few but it shouldn't be bad. I'm actually working on it right now.
This comment has been minimized.
jdalton repliedSep 8, 2010
Woot! I should probably look into this for FuseJS too. I currently share a lot of variables between modules and rely on a custom build process like MooTools to keep the primary closure. I feel like singing a little Boys II Men for the memory of the private variables awesomeness :{D
This comment has been minimized.
helianthus repliedSep 11, 2010
I have just noticed that this commit breaks
jQuery.animate
since some variables likerdashAlpha
andfcamelCase
are nowundefined
.This comment has been minimized.
jeresig repliedSep 12, 2010
@helianthus: Actually already fixed it - but just noticed that it was in a separate branch. You can see it over here: a166860 (it will be merged into the main branch very soon)