Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Switch from recursion to iteration for event triggering. Move event-n…
…ame namespace processing out of event handler, since it has to always go through trigger.
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -277,13 +277,12 @@ jQuery.event = { | ||
| } | ||
| }, | ||
|
|
||
| trigger: function( event, data, elem ) { | ||
| // Event object or event type | ||
| var type = event.type || event, | ||
| bubbling = arguments[3], | ||
| namespaces = []; | ||
|
|
||
| event = typeof event === "object" ? | ||
| // jQuery.Event object | ||
| event[ jQuery.expando ] ? event : | ||
| @@ -293,10 +292,19 @@ jQuery.event = { | ||
| jQuery.Event(type); | ||
|
|
||
| if ( type.indexOf("!") >= 0 ) { | ||
| // Exclusive events trigger only for the bare event type (no namespaces) | ||
This comment has been minimized.
Sorry, something went wrong. |
||
| event.type = type = type.slice(0, -1); | ||
| event.exclusive = true; | ||
| } | ||
| if ( type.indexOf(".") >= 0 ) { | ||
| // Namespaced trigger; create a regexp to match event type in handle() | ||
| namespaces = type.split("."); | ||
| event.type = type = namespaces.shift(); | ||
| namespaces.sort(); | ||
| } | ||
| event.namespace = namespaces.join("."); | ||
| event.namespace_re = new RegExp("(^|\\.)" + namespaces.join("\\.(?:.*\\.)?") + "(\\.|$)"); | ||
|
|
||
This comment has been minimized.
Sorry, something went wrong. 
rwaldron
Member
|
||
| // Handle a global trigger | ||
| if ( !elem ) { | ||
| // Don't bubble custom events when global (to avoid too much overhead) | ||
| @@ -317,13 +325,12 @@ jQuery.event = { | ||
| } | ||
| }); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| // don't do events on text and comment nodes | ||
| if ( elem.nodeType === 3 || elem.nodeType === 8 ) { | ||
| return; | ||
| } | ||
|
|
||
| // Clean up in case it is reused | ||
| @@ -333,62 +340,53 @@ jQuery.event = { | ||
| // Clone the incoming data, if any | ||
| data = jQuery.makeArray( data ); | ||
| data.unshift( event ); | ||
|
|
||
| // Always fire on the current element, e.g. triggerHandler or global trigger | ||
| var cur = elem; | ||
| do { | ||
| var handle = jQuery._data( cur, "handle" ); | ||
|
|
||
| event.currentTarget = cur; | ||
| if ( handle ) { | ||
This comment has been minimized.
Sorry, something went wrong. |
||
| handle.apply( cur, data ); | ||
This comment has been minimized.
Sorry, something went wrong. |
||
| } | ||
|
|
||
| // Trigger an inline bound script; IE dies on special-char event names | ||
| try { | ||
| if ( jQuery.acceptData( cur ) && cur[ "on" + type ] && cur[ "on" + type ].apply( cur, data ) === false ) { | ||
| event.result = false; | ||
| event.preventDefault(); | ||
| } | ||
| } catch ( ieError ) {} | ||
|
|
||
| cur = cur.parentNode || cur.ownerDocument; | ||
| } while ( cur && !event.isPropagationStopped() ); | ||
|
|
||
| // If nobody prevented the default action, do it now | ||
| if ( !event.isDefaultPrevented() ) { | ||
| var old, | ||
| special = jQuery.event.special[ type ] || {}; | ||
|
|
||
| if ( (!special._default || special._default.call( elem.ownerDocument, event ) === false) && | ||
| !(type === "click" && jQuery.nodeName( elem, "a" )) && jQuery.acceptData( elem ) ) { | ||
|
|
||
| // IE may die here on non-alpha event names or hidden elements (#3533) | ||
| try { | ||
| if ( elem[ type ] ) { | ||
| // Don't accidentally re-trigger the onFOO events | ||
| old = elem[ "on" + type ]; | ||
|
|
||
| if ( old ) { | ||
| elem[ "on" + type ] = null; | ||
| } | ||
|
|
||
| jQuery.event.triggered = event.type; | ||
| elem[ type ](); | ||
| } | ||
| } catch ( ieError ) {} | ||
|
|
||
| if ( old ) { | ||
| elem[ "on" + type ] = old; | ||
| } | ||
|
|
||
| jQuery.event.triggered = undefined; | ||
| @@ -397,38 +395,24 @@ jQuery.event = { | ||
| }, | ||
|
|
||
| handle: function( event ) { | ||
| // It's rare to arrive without handlers to call, so do all setup here. | ||
| // Copy the handler list since a called handler may add/remove events. | ||
| event = jQuery.event.fix( event || window.event ); | ||
| var events = jQuery._data( this, "events" ), | ||
| handlers = ((events || {})[ event.type ] || []).slice(0), | ||
| all_handlers = !event.exclusive && !event.namespace, | ||
| args = jQuery.makeArray( arguments ); | ||
|
|
||
| // Use the fix-ed Event rather than the (read-only) native event | ||
| args[0] = event; | ||
| event.currentTarget = this; | ||
|
|
||
| for ( var j = 0, l = handlers.length; j < l; j++ ) { | ||
| var handleObj = handlers[ j ]; | ||
|
|
||
| // Triggered event must 1) be non-exclusive and have no namespace, or | ||
| // 2) have namespace(s) a subset or equal to those in the bound event. | ||
| if ( all_handlers || event.namespace_re.test( handleObj.namespace ) ) { | ||
| // Pass in a reference to the handler function itself | ||
| // So that we can later remove it | ||
| event.handler = handleObj.handler; | ||
| @@ -450,8 +434,6 @@ jQuery.event = { | ||
| } | ||
| } | ||
| } | ||
| return event.result; | ||
| }, | ||
|
|
||
I think the tabs on github are just confused by this comment being one tab left.