Skip to content
Permalink
Browse files

Landed a proper fix for #3255 - which involves doing createElement in…

…stead of going through the normal clean method.
  • Loading branch information
jeresig committed Jan 3, 2009
1 parent cff37cc commit c0294278db40da764a98ea1c1506548e539213c7
Showing with 12 additions and 8 deletions.
  1. +8 −6 src/core.js
  2. +4 −2 test/unit/core.js
@@ -819,6 +819,14 @@ jQuery.extend({
if ( typeof context.createElement === "undefined" )
context = context.ownerDocument || context[0] && context[0].ownerDocument || document;

// If a single string is passed in and it's a single tag
// just do a createElement and skip the rest
if ( !fragment && elems.length === 1 && typeof elems[0] === "string" ) {
var match = /^<(\w+)\/?>$/.exec(elems[0]);
if ( match )
return [ context.createElement( match[1] ) ];
}

var ret = [], scripts = [], div = context.createElement("div");

jQuery.each(elems, function(i, elem){
@@ -915,12 +923,6 @@ jQuery.extend({

});

// Clean up
// Safari 3.1 throws an exception when a colgroup is created
try {
div.innerHTML = "";
} catch(e){}

if ( fragment ) {
for ( var i = 0; ret[i]; i++ ) {
var node = ret[i];
@@ -254,7 +254,7 @@ test("isFunction", function() {
var foo = false;

test("jQuery('html')", function() {
expect(6);
expect(8);

reset();
foo = false;
@@ -267,7 +267,9 @@ test("jQuery('html')", function() {
reset();
ok( jQuery("<link rel='stylesheet'/>")[0], "Creating a link" );

reset();
ok( !jQuery("<script/>")[0].parentNode, "Create a script" );

ok( jQuery("<input/>").attr("type", "hidden"), "Create an input and set the type." );

var j = jQuery("<span>hi</span> there <!-- mon ami -->");
ok( j.length >= 2, "Check node,textnode,comment creation (some browsers delete comments)" );

0 comments on commit c029427

Please sign in to comment.
You can’t perform that action at this time.