Permalink
Show file tree
Hide file tree
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Reduce the boolean list only to those that have corresponding IDLs th…
…at don't require being added to propFix; only set the IDL if it exists - See http://jsfiddle.net/timmywil/u5NLn/ for how boolean attributes are handled in every browser.
- Loading branch information
timmywil
committed
May 7, 2011
1 parent
09c0cf9
commit c085563
Showing
2 changed files
with
18 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c085563
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand your list. Following your approach, we should also use the following names:
not supported by any browser yet
The fact, that they always return undefined in all current browsers only means, that there is no support, but from spec, they all behave equal to other attributes in the current list:
a) equal to reflecting boolean attributes
- pubdate ( pubDate )
- reversed
- scoped
- seamless
b) equal to not reflecting boolean attributes (i.e.: checked).
- muted (the idl is currently supported by modern browsers, but not the content-attribute to set the initial value. There is also a defaultMuted property)
deprecated/ not often used attributes
My list reducation proposal was heavyly influenced by only adding attributes for back-compat issues. While you try to handle all boolean content-attributes, which have a corresponding idl attribute the same. This means, that also deprecated and less known attributes can be in this list.
a) deprecated attributes
- autobuffer (only supported by FF3.5/3.6)
- truespeed (trueSpeed)
b) less known/less used attributes
- ismap
- declare
c085563
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scoped has an idl in IE. The others do not yet have support in any browser. I think we can cross that bridge when they do or we might not be returning consistent values (I'd rather return empty string over undefined for now when those are simply present on the DOM with no value; in a sense, we can rely on the user more for those). As for muted, I'm not sure how to support that without extra code (the audio attribute on a video element sets the muted property for video). The deprecated attributes you mention weren't "supported" in the past and I'd rather push towards keeping them deprecated in the name of progressive enhancement (esp. since there's no backcompat issues there). isMap would require an addition to propFix, so I don't think that's worth it since as you say it is rare. Finally, declare is also deprecated.