Skip to content

Commit

Permalink
Build: Remove obsolete globals from ESLint configuration
Browse files Browse the repository at this point in the history
We had quite a few obsolete globals declared in various ESLint config files. We also no longer allow to rely on the `noGlobal` & `jQuery` globals in the built file which is not needed.

Closes gh-4301
  • Loading branch information
mgol committed Feb 19, 2019
1 parent 8751e9e commit c10945d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
4 changes: 1 addition & 3 deletions .eslintrc-browser.json
Expand Up @@ -19,10 +19,8 @@

"globals": {
"window": true,
"jQuery": true,
"define": true,
"module": true,
"noGlobal": true
"module": true
},

"rules": {
Expand Down
6 changes: 5 additions & 1 deletion src/.eslintrc.json
@@ -1,5 +1,9 @@
{
"root": true,

"extends": "../.eslintrc-browser.json"
"extends": "../.eslintrc-browser.json",

"globals": {
"jQuery": true
}
}
7 changes: 0 additions & 7 deletions test/.eslintrc.json
Expand Up @@ -12,22 +12,15 @@

"globals": {
"require": false,
"define": false,
"DOMParser": false,
"JSON": false,
"Promise": false,
"Symbol": false,
"QUnit": false,
"ajaxTest": false,
"testIframe": false,
"testIframeWithCallback": false,
"iframeCallback": true,
"createDashboardXML": false,
"createXMLFragment": false,
"moduleTeardown": false,
"testFoo": false,
"url": false,
"t": false,
"q": false,
"jQuery": true,
"sinon": true,
Expand Down

0 comments on commit c10945d

Please sign in to comment.