Skip to content
Permalink
Browse files

Global found in dataAttr function

  • Loading branch information
timmywil
timmywil committed May 6, 2011
1 parent c72b0f3 commit c864455ccfad13895d2af6ba287f265ee64bd348
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/data.js
@@ -284,7 +284,7 @@ function dataAttr( elem, key, data ) {
// If nothing was found internally, try to fetch any
// data from the HTML5 data-* attribute
if ( data === undefined && elem.nodeType === 1 ) {
name = "data-" + key.replace( rmultiDash, "$1-$2" ).toLowerCase();
var name = "data-" + key.replace( rmultiDash, "$1-$2" ).toLowerCase();

data = elem.getAttribute( name );

4 comments on commit c864455

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer replied May 7, 2011

I also saw a "value" global when running validation plugin's testsuite with 1.6 and latest with noglobals on. Did you find that one?

@timmywil

This comment has been minimized.

Copy link
Member

timmywil replied May 7, 2011

I ran it through strict mode and lint and didn't see it, but I'll do a dommonster check.

@jzaefferer

This comment has been minimized.

Copy link
Member

jzaefferer replied May 7, 2011

Did you check the testsuite with ?noglobals=true ? There's a checkbox for that in the header.

@timmywil

This comment has been minimized.

Copy link
Member

timmywil replied May 7, 2011

Got it, thanks Jörn!

Please sign in to comment.
You can’t perform that action at this time.