Permalink
7 comments
on commit
sign in to comment.
Submodule sizzle
updated
6 files
+1 −0 | AUTHORS.txt | |
+5 −5 | bower.json | |
+2 −2 | dist/sizzle.js | |
+1 −1 | dist/sizzle.min.js | |
+1 −1 | dist/sizzle.min.map | |
+1 −1 | sizzle.js |
This comment has been minimized.
serbanghita repliedJul 12, 2013
@timmywil why was undefined removed? Shouldn't it protect jQuery from user overwriting the
undefined
variable? ThanksThis comment has been minimized.
mgol repliedJul 12, 2013
@serbanghita It's because most projects don't protect against such overwriting so if anyone does that (but.. why?) they're already screwed on so many levels...
This comment has been minimized.
FagnerMartinsBrack repliedJul 12, 2013
Isn't
undefined
turned into an undefined variable to reduce size on minification? Not familiarized with the codebase btw, just watching.This comment has been minimized.
timmywil repliedJul 13, 2013
It wasn't saving us that much so the team agreed we'd rather not have it.
This comment has been minimized.
davidmurdoch repliedJul 16, 2013
Is there any benefit in removing
undefined
?This comment has been minimized.
timmywil repliedJul 16, 2013
@davidmurdoch There isn't enough benefit in having it. But yes, one benefit is that it clears up parameters for an eventual jQuery-creating factory (where jQuery could be re-created with a different context and we can document the factory's signature without worrying about this unnecessary undefined variable). We could do
var undefined
instead at the top of the closure, but like I said, there isn't enough benefit.This comment has been minimized.
davidmurdoch repliedJul 17, 2013
I do wonder what the GZIP byte diff is for
undefined
parameter vsvar undefined
, vs the omittedundefined?
If you have them, can you publish them here?