Permalink
2 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca49ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you do the same in the following lines?
jquery/src/manipulation.js
Line 308 in ca49ef9
jquery/src/manipulation.js
Line 374 in ca49ef9
jquery/src/manipulation.js
Line 438 in ca49ef9
(didn't had a look into other modules, which may would benefit also from this change...)
ca49ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On those lines, each element of a list must be converted into an argument for
push
. The ones I changed are strictly single-object additions, and so don't needapply
.