Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
IE9's support for SVG elements unfortunately does not extend to clear…
…Attributes. Checks for its presence before proceeding.
- Loading branch information
Showing
2 changed files
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -388,11 +388,15 @@ function cloneFixAttributes( src, dest ) { | ||
|
||
// clearAttributes removes the attributes, which we don't want, | ||
// but also removes the attachEvent events, which we *do* want | ||
dest.clearAttributes(); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
timmywil
Member
|
||
if ( dest.clearAttributes ) { | ||
dest.clearAttributes(); | ||
} | ||
|
||
// mergeAttributes, in contrast, only merges back on the | ||
// original attributes, not the events | ||
dest.mergeAttributes(src); | ||
if ( dest.mergeAttributes ) { | ||
dest.mergeAttributes( src ); | ||
} | ||
|
||
// IE6-8 fail to clone children inside object elements that use | ||
// the proprietary classid attribute value (rather than the type | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should IE9 be in cloneFixAttributes? It's not using attachEvent except perhaps in special events, and there is already an open ticket for event problems caused by cloning special events. I suspect it got here due to noCloneChecked, unless the support.js rewrite introduced a bug.