Permalink
3 comments
on commit
sign in to comment.
Browse files
Catch one more place where a plain-text error was thrown.
- Loading branch information...
This comment has been minimized.
jaubourg repliedNov 8, 2011
Hmmm... you probably shouldn't here. We're supposed to give the exception object to the error callbacks. What are we trying to handle here exactly ?
This comment has been minimized.
dmethvin repliedNov 8, 2011
Oh good, daddy is here! :)
IE won't give the user any useful error information if a plain string is thrown, so we changed
jQuery.errortothrow new Error(msg)instead. Since ajax uses it to throw in the transports I needed to find the places it was expecting strings. Thoughts?This comment has been minimized.
jaubourg repliedNov 8, 2011
Well, it's not actually expecting a string here, because it's catching around the use of converters (where native exceptions can be thrown depending on how such or such converter is implemented). The third parameter of the error callbacks (which is the sole use of the error variable here) is supposed to be the original exception whenever available. In fact same goes for transports actually.