Skip to content
Permalink
Browse files
Tests: Improve jsonp tests
Since global variable for callback always would be equal to undefined value
it better to check for boolean instead
  • Loading branch information
markelog committed Apr 15, 2014
1 parent ebbbe96 commit cd546aba748aeac09886921ebc1a5fcaa3778bf8
Showing 1 changed file with 2 additions and 2 deletions.
@@ -733,7 +733,7 @@ module( "ajax", {
jsonpCallback: "functionToCleanUp",
success: function( data ) {
ok( data["data"], "JSON results returned (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], undefined, "Callback was removed (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], true, "Callback was removed (GET, custom callback name to be cleaned up)" );
var xhr;
jQuery.ajax({
url: "data/jsonp.php",
@@ -747,7 +747,7 @@ module( "ajax", {
});
xhr.fail(function() {
ok( true, "Ajax error JSON (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], undefined, "Callback was removed after early abort (GET, custom callback name to be cleaned up)" );
strictEqual( window["functionToCleanUp"], true, "Callback was removed after early abort (GET, custom callback name to be cleaned up)" );
});
}
}, {

0 comments on commit cd546ab

Please sign in to comment.