Permalink
Browse files

Fix #13810: .replaceWith(nextSibling)

  • Loading branch information...
gibson042 committed Apr 23, 2013
1 parent 67a080b commit d8f7e8371230a6dd504ca02e65442745b6ff6ce2
Showing with 17 additions and 1 deletion.
  1. +4 −0 src/manipulation.js
  2. +13 −1 test/unit/manipulation.js
@@ -173,6 +173,10 @@ jQuery.fn.extend({
parent = args[ i++ ];

if ( parent ) {
// Don't use the snapshot next if it has moved (#13810)
if ( next && next.parentNode !== parent ) {
next = this.nextSibling;
}
jQuery( this ).remove();
parent.insertBefore( elem, next );
}
@@ -879,7 +879,7 @@ test( "insertAfter(String|Element|Array<Element>|jQuery)", function() {
function testReplaceWith( val ) {

var tmp, y, child, child2, set, non_existent, $div,
expected = 26;
expected = 29;

expect( expected );

@@ -955,6 +955,18 @@ function testReplaceWith( val ) {
equal( set[0].childNodes.length, 0, "No effect on a disconnected node." );


child = jQuery("#qunit-fixture").children().first();
$div = jQuery("<div class='pathological'/>").insertBefore( child );
$div.replaceWith( $div );
deepEqual( jQuery( ".pathological", "#qunit-fixture" ).get(), $div.get(),
"Self-replacement" );
$div.replaceWith( child );
deepEqual( jQuery("#qunit-fixture").children().first().get(), child.get(),
"Replacement with following sibling (#13810)" );
deepEqual( jQuery( ".pathological", "#qunit-fixture" ).get(), [],
"Replacement with following sibling (context removed)" );


non_existent = jQuery("#does-not-exist").replaceWith( val("<b>should not throw an error</b>") );
equal( non_existent.length, 0, "Length of non existent element." );

0 comments on commit d8f7e83

Please sign in to comment.