Skip to content
Permalink
Browse files

Fix #10812, let .before() and .after() work on empty collections.

  • Loading branch information...
dmethvin committed Nov 17, 2011
1 parent 7c2d6c8 commit dd845a2c0f63f97e74e4d490ee66e12e0bf180c5
Showing with 10 additions and 2 deletions.
  1. +2 −2 src/manipulation.js
  2. +8 −0 test/unit/manipulation.js
@@ -154,7 +154,7 @@ jQuery.fn.extend({
this.parentNode.insertBefore( elem, this );
});
} else if ( arguments.length ) {
var set = jQuery(arguments[0]);
var set = jQuery.clean( arguments );
set.push.apply( set, this.toArray() );
return this.pushStack( set, "before", arguments );
}
@@ -167,7 +167,7 @@ jQuery.fn.extend({
});
} else if ( arguments.length ) {
var set = this.pushStack( this, "after", arguments );
set.push.apply( set, jQuery(arguments[0]).toArray() );
set.push.apply( set, jQuery.clean(arguments) );
return set;
}
},
@@ -794,6 +794,14 @@ test("before(Function)", function() {
testBefore(functionReturningObj);
})

test("before and after w/ empty object (#10812)", function() {
expect(2);

var res = jQuery( "#notInTheDocument" ).before( "(" ).after( ")" );
equal( res.length, 2, "didn't choke on empty object" );
equal( res.wrap("<div/>").parent().text(), "()", "correctly appended text" );
});

test("insertBefore(String|Element|Array&lt;Element&gt;|jQuery)", function() {
expect(4);
var expected = "This is a normal link: bugaYahoo";

0 comments on commit dd845a2

Please sign in to comment.
You can’t perform that action at this time.