Skip to content
Permalink
Browse files

Skip id regex check when large html strings are passed to the jQuery …

…constructor (#7990).
  • Loading branch information...
carpie authored and dmethvin committed Jan 19, 2011
1 parent ceaf093 commit e0856738e6151368cffc963800e06ebcc0bbc314
Showing with 20 additions and 2 deletions.
  1. +6 −1 src/core.js
  2. +14 −1 test/unit/core.js
@@ -96,7 +96,12 @@ jQuery.fn = jQuery.prototype = {
// Handle HTML strings
if ( typeof selector === "string" ) {
// Are we dealing with HTML string or an ID?
match = quickExpr.exec( selector );
if ( selector.length > 1024 ) {

This comment has been minimized.

Copy link
@jdalton

jdalton Apr 16, 2011

Member

I am geeking out over the bug and the fix. srsly awesome.

// Assume very large strings are HTML and skip the regex check
match = [ null, selector, null ];
} else {
match = quickExpr.exec( selector );
}

// Verify a match, and that no context was specified for #id
if ( match && (match[1] || !context) ) {
@@ -469,7 +469,7 @@ test("isWindow", function() {
});

test("jQuery('html')", function() {
expect(15);
expect(18);

QUnit.reset();
jQuery.foo = false;
@@ -501,6 +501,19 @@ test("jQuery('html')", function() {

ok( jQuery("<div></div>")[0], "Create a div with closing tag." );
ok( jQuery("<table></table>")[0], "Create a table with closing tag." );

// Test very large html string #7990
var i;
var li = '<li>very large html string</li>';
var html = ['<ul>'];
for ( i = 0; i < 50000; i += 1 ) {
html.push(li);
}
html.push('</ul>');
html = jQuery(html.join(''))[0];
equals( html.nodeName.toUpperCase(), 'UL');
equals( html.firstChild.nodeName.toUpperCase(), 'LI');
equals( html.childNodes.length, 50000 );
});

test("jQuery('html', context)", function() {

0 comments on commit e085673

Please sign in to comment.
You can’t perform that action at this time.