Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
User internalKey instead of jQuery.expando. Fixes #10675
  • Loading branch information
rwaldron authored and dmethvin committed Nov 6, 2011
1 parent 262c32a commit e086c22
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/data.js
Expand Up @@ -46,7 +46,7 @@ jQuery.extend({

// Only defining an ID for JS objects if its cache already exists allows
// the code to shortcut on the same path as a DOM node with no cache
id = isNode ? elem[ jQuery.expando ] : elem[ jQuery.expando ] && jQuery.expando,
id = isNode ? elem[ internalKey ] : elem[ internalKey ] && internalKey,
isEvents = name === "events";

// Avoid doing any more work than we need to when trying to get data on an
Expand All @@ -59,9 +59,9 @@ jQuery.extend({
// Only DOM nodes need a new unique ID for each element since their data
// ends up in the global cache
if ( isNode ) {
elem[ jQuery.expando ] = id = ++jQuery.uuid;
elem[ internalKey ] = id = ++jQuery.uuid;
} else {
id = jQuery.expando;
id = internalKey;
}
}

Expand Down Expand Up @@ -144,7 +144,7 @@ jQuery.extend({
cache = isNode ? jQuery.cache : elem,

// See jQuery.data for more information
id = isNode ? elem[ jQuery.expando ] : jQuery.expando;
id = isNode ? elem[ internalKey ] : internalKey;

// If there is already no cache entry for this object, there is no
// purpose in continuing
Expand Down Expand Up @@ -214,11 +214,11 @@ jQuery.extend({
// nor does it have a removeAttribute function on Document nodes;
// we must handle all of these cases
if ( jQuery.support.deleteExpando ) {
delete elem[ jQuery.expando ];
delete elem[ internalKey ];
} else if ( elem.removeAttribute ) {
elem.removeAttribute( jQuery.expando );
elem.removeAttribute( internalKey );
} else {
elem[ jQuery.expando ] = null;
elem[ internalKey ] = null;
}
}
},
Expand Down

0 comments on commit e086c22

Please sign in to comment.