Skip to content
Permalink
Browse files
Remove unnecessary background setting in support now that we have the…
… div reversion. Test added.
  • Loading branch information
timmywil committed May 25, 2011
1 parent b43910a commit e5457a5a1faa642b0af13e87ee3f76f2ef704b30
Showing 2 changed files with 5 additions and 3 deletions.
@@ -147,9 +147,7 @@ jQuery.support = (function() {
width: 0,
height: 0,
border: 0,
margin: 0,
// Set background to avoid IE crashes when removing (#9028)
background: "none"
margin: 0
};
if ( body ) {
jQuery.extend( testElementStyle, {
@@ -117,3 +117,7 @@ v\:oval { behavior:url(#default#VML); display:inline-block; }
tt { display: none; }
sup { display: none; }
dfn { display: none; }

/* #9239 Attach a background to the body( avoid crashes in removing the test element in support ) */
body { background: url(http://www.ctemploymentlawblog.com/test.jpg) no-repeat -1000px 0; }

1 comment on commit e5457a5

@brewdente
Copy link

@brewdente brewdente commented on e5457a5 Jul 29, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE8 still appears to crash when the testElement is removed. Putting back the 'background: "none"' in the testElementStyle appears to make IE8 happy (not crash). I tried to create a Fiddle but, weirdly, I couldn't get it to crash there. As far as I can tell, most of the time the body element is already in the DOM and the test element is a DIV. I notice the crash more consistently when I fire up a new iexplorer process and visit a page which uses jQuery (currently 1.6.2). Once the page is loaded, the crash is much less consistent (perhaps IE is doing some BODY caching/magic for performance?).

Please sign in to comment.