Skip to content
Permalink
Browse files

Make sure the resulting className from removeClass is nicely trimmed.…

… Fixes #5988.
  • Loading branch information
jeresig committed Feb 2, 2010
1 parent f95147f commit e76ba32cebc26108e15b2e0e03c5152624c1bad9
Showing with 13 additions and 2 deletions.
  1. +1 −1 src/attributes.js
  2. +12 −1 test/unit/attributes.js
@@ -74,7 +74,7 @@ jQuery.fn.extend({
for ( var c = 0, cl = classNames.length; c < cl; c++ ) {
className = className.replace(" " + classNames[c] + " ", " ");
}
elem.className = className.substring(1, className.length - 1);
elem.className = jQuery.trim( className );

} else {
elem.className = "";
@@ -478,7 +478,7 @@ test("addClass(Function) with incoming value", function() {
});

var testRemoveClass = function(valueObj) {
expect(5);
expect(7);

var $divs = jQuery('div');

@@ -508,6 +508,17 @@ var testRemoveClass = function(valueObj) {
var j = jQuery("#nonnodes").contents();
j.removeClass( valueObj("asdf") );
ok( !j.hasClass("asdf"), "Check node,textnode,comment for removeClass" );

var div = document.createElement("div");
div.className = " test foo ";

jQuery(div).removeClass( valueObj("foo") );
equals( div.className, "test", "Make sure remaining className is trimmed." );

div.className = " test ";

jQuery(div).removeClass( valueObj("test") );
equals( div.className, "", "Make sure there is nothing left after everything is removed." );
};

test("removeClass(String) - simple", function() {

0 comments on commit e76ba32

Please sign in to comment.
You can’t perform that action at this time.