Permalink
Browse files

Manipulation: don't auto-insert tbody

Fixes gh-1835
Closes gh-2021
  • Loading branch information...
markelog committed Jan 21, 2015
1 parent 0ea342a commit e984d1c79cc476062818e03df04a366baa13d197
Showing with 81 additions and 6 deletions.
  1. +6 −6 src/manipulation.js
  2. +75 −0 test/unit/manipulation.js
View
@@ -57,14 +57,14 @@ wrapMap.optgroup = wrapMap.option;
wrapMap.tbody = wrapMap.tfoot = wrapMap.colgroup = wrapMap.caption = wrapMap.thead;
wrapMap.th = wrapMap.td;
-// Manipulating tables requires a tbody
function manipulationTarget( elem, content ) {
- return jQuery.nodeName( elem, "table" ) &&
- jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ?
+ if ( jQuery.nodeName( elem, "table" ) &&
+ jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ) {
- elem.getElementsByTagName("tbody")[0] ||
- elem.appendChild( elem.ownerDocument.createElement("tbody") ) :
- elem;
+ return elem.getElementsByTagName( "tbody" )[ 0 ] || elem;
+ }
+
+ return elem;
}
// Replace/restore the type attribute of script elements for safe DOM manipulation
View
@@ -2452,6 +2452,81 @@ test( "Validate creation of multiple quantities of certain elements (#13818)", 4
});
});
+test( "Make sure tr element will be appended to tbody element of table when present", function() {
+ expect( 1 );
+
+ var html,
+ table = document.createElement( "table" );
+
+ table.appendChild( document.createElement( "tbody" ) );
+ document.getElementById( "qunit-fixture" ).appendChild( table );
+
+ jQuery( table ).append( "<tr><td>test</td></tr>" );
+
+ // Lowercase and replace spaces to remove possible browser inconsistencies
+ html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
+
+ strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
+});
+
+test( "Make sure tr elements will be appended to tbody element of table when present", function() {
+ expect( 1 );
+
+ var html,
+ table = document.createElement( "table" );
+
+ table.appendChild( document.createElement( "tbody" ) );
+ document.getElementById( "qunit-fixture" ).appendChild( table );
+
+ jQuery( table ).append( "<tr><td>1</td></tr><tr><td>2</td></tr>" );
+
+ // Lowercase and replace spaces to remove possible browser inconsistencies
+ html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
+
+ strictEqual( html, "<tbody><tr><td>1</td></tr><tr><td>2</td></tr></tbody>" );
+});
+
+test( "Make sure tfoot element will not be appended to tbody element of table when present", function() {
+ expect( 1 );
+
+ var html,
+ table = document.createElement( "table" );
+
+ table.appendChild( document.createElement( "tbody" ) );
+ document.getElementById( "qunit-fixture" ).appendChild( table );
+
+ jQuery( table ).append( "<tfoot/>" );
+
+ // Lowercase and replace spaces to remove possible browser inconsistencies
+ html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
+
+ strictEqual( html, "<tbody></tbody><tfoot></tfoot>" );
+});
+
+test( "Make sure document fragment will be appended to tbody element of table when present", function() {
+ expect( 1 );
+
+ var html,
+ fragment = document.createDocumentFragment(),
+ table = document.createElement( "table" ),
+ tr = document.createElement( "tr" ),
+ td = document.createElement( "td" );
+
+ table.appendChild( document.createElement( "tbody" ) );
+ document.getElementById( "qunit-fixture" ).appendChild( table );
+
+ fragment.appendChild( tr );
+ tr.appendChild( td );
+ td.innerHTML = "test";
+
+ jQuery( table ).append( fragment );
+
+ // Lowercase and replace spaces to remove possible browser inconsistencies
+ html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
+
+ strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
+});
+
test( "Make sure col element is appended correctly", function() {
expect( 1 );

0 comments on commit e984d1c

Please sign in to comment.