Skip to content
Permalink
Browse files

Fixed #1070 by converting all setAttribute() values to a string which…

… is what all browsers but IE did. This will bring IE in line with the others and fix the bug.
  • Loading branch information
davids549 committed Nov 28, 2007
1 parent 3ae5fbc commit ed7608d8eedc0cd9082b5246581c0fc4ccb392db
Showing with 11 additions and 2 deletions.
  1. +2 −1 src/core.js
  2. +9 −1 test/unit/core.js
@@ -1042,7 +1042,8 @@ jQuery.extend({
if ( name == "type" && jQuery.nodeName( elem, "input" ) && elem.parentNode )
throw "type property can't be changed";

elem.setAttribute( name, value );
// convert the value to a string (all browsers do this but IE) see #1070
elem.setAttribute( name, "" + value );
}

if ( jQuery.browser.msie && /href|src/.test( name ) && !jQuery.isXMLDoc( elem ) )
@@ -276,7 +276,7 @@ test("attr(Hash)", function() {
});

test("attr(String, Object)", function() {
expect(13);
expect(16);
var div = $("div");
div.attr("foo", "bar");
var pass = true;
@@ -302,6 +302,14 @@ test("attr(String, Object)", function() {
$("#name").attr('maxLength', '10');
ok( document.getElementById('name').maxLength == '10', 'Set maxlength attribute' );

// for #1070
$("#name").attr('someAttr', '0');
equals( $("#name").attr('someAttr'), '0', 'Set attribute to a string of "0"' );
$("#name").attr('someAttr', 0);
equals( $("#name").attr('someAttr'), 0, 'Set attribute to the number 0' );
$("#name").attr('someAttr', 1);
equals( $("#name").attr('someAttr'), 1, 'Set attribute to the number 1' );

reset();

var type = $("#check2").attr('type');

0 comments on commit ed7608d

Please sign in to comment.
You can’t perform that action at this time.