Skip to content
Permalink
Browse files

Follow-up for .selector property removal

  • Loading branch information
markelog authored and dmethvin committed Nov 2, 2012
1 parent 240b141 commit f651bf8893ceb585245bfc57ba76d3dcb5d0a3b6
Showing with 5 additions and 9 deletions.
  1. +3 −4 src/core.js
  2. +2 −5 src/traversing.js
@@ -36,7 +36,7 @@ var
// Used for detecting and trimming whitespace
core_rnotwhite = /\S/,
core_rspace = /\s+/,

// List of deleted data cache ids, so we can reuse them
core_deletedIds = [],

@@ -231,8 +231,7 @@ jQuery.fn = jQuery.prototype = {
},

slice: function() {
return this.pushStack( core_slice.apply( this, arguments ),
"slice", core_slice.call(arguments).join(",") );
return this.pushStack( core_slice.apply( this, arguments ) );
},

first: function() {
@@ -493,7 +492,7 @@ jQuery.extend({
}

if ( typeof data === "string" ) {

// Make sure leading/trailing whitespace is removed (IE can't handle it)
data = jQuery.trim( data );

@@ -31,9 +31,8 @@ jQuery.fn.extend({
}

// Needed because $( selector, context ) becomes $( context ).find( selector )
ret = this.pushStack( jQuery.unique( ret ) );
ret.selector = ( this.selector ? this.selector + " " : "" ) + selector;
return ret;
return this.pushStack( jQuery.unique( ret ) );
},

has: function( target ) {
@@ -90,9 +89,7 @@ jQuery.fn.extend({
}
}

ret = ret.length > 1 ? jQuery.unique( ret ) : ret;

return this.pushStack( ret );
return this.pushStack( ret.length > 1 ? jQuery.unique( ret ) : ret );
},

// Determine the position of an element within

2 comments on commit f651bf8

@Krinkle

This comment has been minimized.

Copy link
Member

Krinkle replied Nov 2, 2012

This broke 300+ tests in module "effects" and 5 in "core" (in all browsers).

EDIT: Follow-up: 68f001e.

@gibson042

This comment has been minimized.

Copy link
Member

gibson042 replied Nov 2, 2012

That sounds like a record!

Please sign in to comment.
You can’t perform that action at this time.