Skip to content
Permalink
Browse files
Close php tags for ajax tests on swarm
  • Loading branch information
timmywil committed Aug 19, 2013
1 parent a542590 commit f6e86c3ca4d527d5453a0b5b9591ef38b5d3c000
Showing 3 changed files with 8 additions and 2 deletions.
@@ -3,4 +3,6 @@
header("HTTP/1.0 400 Bad Request");
header("Content-Type: application/json");

echo '{ "code": 40, "message": "Bad Request" }';
echo '{ "code": 40, "message": "Bad Request" }';

?>
@@ -2,4 +2,6 @@

header("HTTP/1.0 400 Bad Request");

echo "plain text message";
echo "plain text message";

?>
@@ -16,3 +16,5 @@
foreach( explode( "_" , $_GET[ "keys" ] ) as $key ) {
echo "$key: " . @$headers[ strtoupper( $key ) ] . "\n";
}

?>

8 comments on commit f6e86c3

@egeriis
Copy link

@egeriis egeriis commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why on earth did you guys add a PHP close tag?

@timmywil
Copy link
Member Author

@timmywil timmywil commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a shot in the dark. I'll have to investigate for real when I have time.

@egeriis
Copy link

@egeriis egeriis commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite a bad practice to do so :)

@timmywil
Copy link
Member Author

@timmywil timmywil commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't happen again :)

@markelog
Copy link
Member

@markelog markelog commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmywil timeouts probably happens because of the all the "sleep" statements.
@gnarf i'm right here?

@gnarf
Copy link
Member

@gnarf gnarf commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my guess as well, there are only so many executors in the pool - Why do we sleep?

@gnarf
Copy link
Member

@gnarf gnarf commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please revert this? :)

@timmywil
Copy link
Member Author

@timmywil timmywil commented on f6e86c3 Aug 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

Please sign in to comment.