Skip to content
Permalink
Browse files

Close php tags for ajax tests on swarm

  • Loading branch information...
timmywil committed Aug 19, 2013
1 parent a542590 commit f6e86c3ca4d527d5453a0b5b9591ef38b5d3c000
Showing with 8 additions and 2 deletions.
  1. +3 −1 test/data/errorWithJSON.php
  2. +3 −1 test/data/errorWithText.php
  3. +2 −0 test/data/headers.php
@@ -3,4 +3,6 @@
header("HTTP/1.0 400 Bad Request");
header("Content-Type: application/json");
echo '{ "code": 40, "message": "Bad Request" }';
echo '{ "code": 40, "message": "Bad Request" }';
?>
@@ -2,4 +2,6 @@
header("HTTP/1.0 400 Bad Request");
echo "plain text message";
echo "plain text message";
?>
@@ -16,3 +16,5 @@
foreach( explode( "_" , $_GET[ "keys" ] ) as $key ) {
echo "$key: " . @$headers[ strtoupper( $key ) ] . "\n";
}
?>

8 comments on commit f6e86c3

@egeriis

This comment has been minimized.

Copy link

egeriis replied Aug 19, 2013

Why on earth did you guys add a PHP close tag?

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Aug 19, 2013

Just a shot in the dark. I'll have to investigate for real when I have time.

@egeriis

This comment has been minimized.

Copy link

egeriis replied Aug 19, 2013

It's quite a bad practice to do so :)

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Aug 19, 2013

Won't happen again :)

@markelog

This comment has been minimized.

Copy link
Member

markelog replied Aug 19, 2013

@timmywil timeouts probably happens because of the all the "sleep" statements.
@gnarf i'm right here?

@gnarf

This comment has been minimized.

Copy link
Member

gnarf replied Aug 19, 2013

That's my guess as well, there are only so many executors in the pool - Why do we sleep?

@gnarf

This comment has been minimized.

Copy link
Member

gnarf replied Aug 19, 2013

And please revert this? :)

@timmywil

This comment has been minimized.

Copy link
Member Author

timmywil replied Aug 19, 2013

Reverted.

Please sign in to comment.
You can’t perform that action at this time.