Permalink
Browse files

Dimensions: allow modification of coordinates argument

Fixes gh-1848
Closes gh-1853
  • Loading branch information...
markelog committed Nov 11, 2014
1 parent 9d6beac commit f7e60dc83d81cbf892de9dab39642dd67c49bd23
Showing with 15 additions and 1 deletion.
  1. +3 −1 src/offset.js
  2. +12 −0 test/unit/dimensions.js
View
@@ -51,7 +51,9 @@ jQuery.offset = {
}
if ( jQuery.isFunction( options ) ) {
options = options.call( elem, i, curOffset );
// Use jQuery.extend here to allow modification of coordinates argument (gh-1848)
options = options.call( elem, i, jQuery.extend( {}, curOffset ) );
}
if ( options.top != null ) {
View
@@ -455,4 +455,16 @@ testIframe( "dimensions/documentLarge", "window vs. large document", function( j
ok( jQuery( document ).width() > jQuery( window ).width(), "document width is larger than window width" );
});
test( "allow modification of coordinates argument (gh-1848)", 1, function() {
var element = jQuery( "<div/>" ).appendTo( "#qunit-fixture" );
element.offset(function( index, coords ) {
coords.top = 100;
return coords;
});
equal( element.offset().top, 100, "coordinates are modified" );
});
})();

0 comments on commit f7e60dc

Please sign in to comment.