Permalink
Show file tree
Hide file tree
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Merge branch 'fix_suite_fails' of https://github.com/timmywil/jquery …
…into timmywil-fix_suite_fails
- Loading branch information
Showing
4 changed files
with
14 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7f4ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intended that the VML element be present for all tests. If it causes failures, that indicates additional places where jQuery needs to apply workarounds.
f7f4ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfirebaugh, I'm not clear on your comment. Are these changes not correct? I haven't been following the history of this patch.
f7f4ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfirebaugh: It's more that he was hoping to catch other weird edge cases by having the VML element in the DOM - but this probably wouldn't happen because we don't touch the whole DOM on every test. I think what you've done is probably fine for this specific test.
f7f4ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfirebaugh: If you can think of other use cases where it might fail, those should be separate tests so that we can always tell that it's related to vml. Adding any more to the head, and adding the oval where you did, caused other tests to fail that specifically check the number of elements returned, html strings, etc.
f7f4ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timmywil Ah, gotcha. I will circle back and see if some more targeted tests can be added.