Skip to content
Permalink
Browse files

Fix for problem in IE 8 where deserialized (then reserialized) form m…

…arkup was getting malformed. Thanks IE. Fixes #5998.
  • Loading branch information
jeresig committed Feb 2, 2010
1 parent f9417b9 commit f95147f465932cb91e1a6aace50c556820ca4074
Showing with 12 additions and 2 deletions.
  1. +3 −1 src/manipulation.js
  2. +9 −1 test/unit/manipulation.js
@@ -197,13 +197,15 @@ jQuery.fn.extend({
// as properties will not be copied (such as the
// the name attribute on an input).
var html = this.outerHTML, ownerDocument = this.ownerDocument;
if ( !html ) {
if ( !html || jQuery.nodeName( this, "form" ) ) {
var div = ownerDocument.createElement("div");
div.appendChild( this.cloneNode(true) );
html = div.innerHTML;
}

return jQuery.clean([html.replace(rinlinejQuery, "")
// Handle the case in IE 8 where action=/test/> self-closes a tag
.replace(/=([^="'>\s]+\/)>/g, '="$1">')
.replace(rleadingWhitespace, "")], ownerDocument)[0];
} else {
return this.cloneNode(true);
@@ -757,7 +757,7 @@ test("replaceAll(String|Element|Array<Element>|jQuery)", function() {
});

test("clone()", function() {
expect(30);
expect(31);
equals( 'This is a normal link: Yahoo', jQuery('#en').text(), 'Assert text for #en' );
var clone = jQuery('#yahoo').clone();
equals( 'Try them out:Yahoo', jQuery('#first').append(clone).text(), 'Check for clone' );
@@ -807,6 +807,14 @@ test("clone()", function() {
div = div.clone(true);
equals( div.data("a"), true, "Data cloned." );
equals( div.data("b"), true, "Data cloned." );

var form = document.createElement("form");
form.action = "/test/";
var div = document.createElement("div");
div.appendChild( document.createTextNode("test") );
form.appendChild( div );

equals( jQuery(form).clone().children().length, 1, "Make sure we just get the form back." );
});

if (!isLocal) {

1 comment on commit f95147f

@jeresig

This comment has been minimized.

Copy link
Member Author

@jeresig jeresig commented on f95147f Feb 2, 2010

Oops, didn't mean to leave that nodeName check in - removed in 8a4b210.

Please sign in to comment.
You can’t perform that action at this time.