Skip to content
Permalink
Browse files

Fix #10943, tabindex not set properly on clone in IE7. Close gh-937.

This is only a unit test fix because the bug was tangentially fixed by a different commit
  • Loading branch information...
mikesherov authored and dmethvin committed Sep 29, 2012
1 parent c3b1367 commit f9ef91d6d68dc7317bb12c1ae2a8201f28facff1
Showing with 23 additions and 18 deletions.
  1. +23 −18 test/unit/attributes.js
@@ -654,41 +654,46 @@ test("prop('tabindex')", function() {
equal(jQuery("#linkWithNoHrefWithNegativeTabIndex").prop("tabindex"), -1, "anchor without href, no tabindex set");
});

test("prop('tabindex', value)", function() {
expect(9);
test("prop('tabindex', value)", 10, function() {

var element = jQuery("#divWithNoTabIndex"),
clone;

var element = jQuery("#divWithNoTabIndex");
equal(element.prop("tabindex"), undefined, "start with no tabindex");

// set a positive string
element.prop("tabindex", "1");
equal(element.prop("tabindex"), 1, "set tabindex to 1 (string)");
element.prop( "tabindex", "1" );
equal( element.prop("tabindex"), 1, "set tabindex to 1 (string)" );

// set a zero string
element.prop("tabindex", "0");
equal(element.prop("tabindex"), 0, "set tabindex to 0 (string)");
element.prop( "tabindex", "0" );
equal( element.prop("tabindex"), 0, "set tabindex to 0 (string)" );

// set a negative string
element.prop("tabindex", "-1");
equal(element.prop("tabindex"), -1, "set tabindex to -1 (string)");
element.prop( "tabindex", "-1" );
equal( element.prop("tabindex"), -1, "set tabindex to -1 (string)" );

// set a positive number
element.prop("tabindex", 1);
equal(element.prop("tabindex"), 1, "set tabindex to 1 (number)");
element.prop( "tabindex", 1 );
equal( element.prop("tabindex"), 1, "set tabindex to 1 (number)" );

// set a zero number
element.prop("tabindex", 0);
equal(element.prop("tabindex"), 0, "set tabindex to 0 (number)");
element.prop( "tabindex", 0 );
equal( element.prop("tabindex"), 0, "set tabindex to 0 (number)" );

// set a negative number
element.prop("tabindex", -1);
equal(element.prop("tabindex"), -1, "set tabindex to -1 (number)");
element.prop( "tabindex", -1 );
equal( element.prop("tabindex"), -1, "set tabindex to -1 (number)" );

element = jQuery("#linkWithTabIndex");
equal(element.prop("tabindex"), 2, "start with tabindex 2");
equal( element.prop("tabindex"), 2, "start with tabindex 2" );

element.prop( "tabindex", -1 );
equal( element.prop("tabindex"), -1, "set negative tabindex" );

element.prop("tabindex", -1);
equal(element.prop("tabindex"), -1, "set negative tabindex");
clone = element.clone();
clone.prop( "tabindex", 1 );
equal( clone[ 0 ].getAttribute("tabindex"), 1, "set tabindex on cloned element" );
});

test("removeProp(String)", function() {

0 comments on commit f9ef91d

Please sign in to comment.
You can’t perform that action at this time.