Permalink
Browse files

Manipulation: Plug an IE8 memory leak in noCloneEvent feature detect

Fixes gh-1840

This feature detect could be simplified now that the only supported browser
with this problem is IE8.
  • Loading branch information...
dmethvin committed Dec 6, 2014
1 parent 4365133 commit faf295a6d85ea716bd795609efdd855938144512
Showing with 2 additions and 10 deletions.
  1. +2 −10 src/manipulation/support.js
@@ -48,16 +48,8 @@ define([
support.checkClone = div.cloneNode( true ).cloneNode( true ).lastChild.checked;
// Support: IE<9
- // Opera does not clone events (and typeof div.attachEvent === undefined).
- // IE9-10 clones events bound via attachEvent, but they don't trigger with .click()
- support.noCloneEvent = true;
- if ( div.attachEvent ) {
- div.attachEvent( "onclick", function() {
- support.noCloneEvent = false;
- });
-
- div.cloneNode( true ).click();
- }
+ // Cloned elements keep attachEvent handlers, we use addEventListener on IE9+
+ support.noCloneEvent = !!div.addEventListener;
// Execute the test only if not already executed in another module.
if (support.deleteExpando == null) {

0 comments on commit faf295a

Please sign in to comment.