Skip to content
Permalink
Browse files

Fixes #7413; isEmptyObject() check to see if obj passes isPlainObject

  • Loading branch information...
rwaldron committed Nov 9, 2010
1 parent a64dc04 commit fc563cc42a4cf9b8d717f1fa4f397e76a132d90a
Showing with 17 additions and 4 deletions.
  1. +6 −0 src/core.js
  2. +11 −4 test/unit/core.js
@@ -532,6 +532,12 @@ jQuery.extend({
},

isEmptyObject: function( obj ) {

// Fixes #7413 Check to see if obj passes isPlainObject
if ( !jQuery.isPlainObject( obj ) ) {
return false;
}

for ( var name in obj ) {
return false;
}
@@ -848,13 +848,20 @@ test("jQuery.makeArray", function(){
});

test("jQuery.isEmptyObject", function(){
expect(2);
expect(11);

equals(true, jQuery.isEmptyObject({}), "isEmptyObject on empty object literal" );
equals(false, jQuery.isEmptyObject({a:1}), "isEmptyObject on non-empty object literal" );

// What about this ?
// equals(true, jQuery.isEmptyObject(null), "isEmptyObject on null" );
equals(false, jQuery.isEmptyObject(1), "isEmptyObject on number (wrong argument type)");
equals(false, jQuery.isEmptyObject(0), "isEmptyObject on falsy number (wrong argument type)");
equals(false, jQuery.isEmptyObject("test"), "isEmptyObject on string (wrong argument type)");
equals(false, jQuery.isEmptyObject(""), "isEmptyObject on falsy string (wrong argument type)");
equals(false, jQuery.isEmptyObject([1,2,3]), "isEmptyObject on array (wrong argument type)");
equals(false, jQuery.isEmptyObject([]), "isEmptyObject on an empty array (wrong argument type)");
equals(false, jQuery.isEmptyObject(undefined), "isEmptyObject on undefined (wrong argument type)");
equals(false, jQuery.isEmptyObject(false), "isEmptyObject on undefined (wrong argument type)");
equals(false, jQuery.isEmptyObject(null), "isEmptyObject on null (wrong argument type)" );

});

test("jQuery.proxy", function(){

0 comments on commit fc563cc

Please sign in to comment.
You can’t perform that action at this time.