Skip to content
Permalink
Browse files

Attrs: Remove outdated valHook for option element

This hook was relevant for BlackBerry 4.7 which is no longer supported.

But this code path now raises error in IE10-11 (#14686) in 1.x-master branch.
So to just to be safe, also add test for IE issue to this branch too.
  • Loading branch information...
markelog committed Jan 12, 2014
1 parent 38c122a commit fdd78fad19ea3390cd96971cd29430e36378d137
Showing with 9 additions and 8 deletions.
  1. +0 −8 src/attributes/val.js
  2. +9 −0 test/unit/attributes.js
@@ -71,14 +71,6 @@ jQuery.fn.extend({

jQuery.extend({
valHooks: {
option: {
get: function( elem ) {
// attributes.value is undefined in Blackberry 4.7 but
// uses .value. See #6932
var val = elem.attributes.value;
return !val || val.specified ? elem.value : elem.text;
}
},
select: {
get: function( elem ) {
var value, option,
@@ -1445,3 +1445,12 @@ test( "coords returns correct values in IE6/IE7, see #10828", function() {
area = map.html("<area shape='rect' coords='0,0,0,0' href='#' alt='a' />").find("area");
equal( area.attr("coords"), "0,0,0,0", "did not retrieve coords correctly" );
});

test( "should not throw at $(option).val() (#14686)", 1, function() {
try {
jQuery( "<option/>" ).val();
ok( true );
} catch ( _ ) {
ok( false );
}
});

0 comments on commit fdd78fa

Please sign in to comment.
You can’t perform that action at this time.