Fix #12149. Avoid memory leak on oldIE change events. Close gh-878.

jquery · Aug 20, 2012 · ff7b7cfd1d754f6daf20541dc71c84ad690d3708 · ff7b7cf
1 parent 9d07525
commit ff7b7cfd1d754f6daf20541dc71c84ad690d3708
Unified Split

Showing with 25 additions and 1 deletion.

+1 −0 AUTHORS.txt

+1 −1 src/event.js

+23 −0 test/unit/event.js
diff --git a/AUTHORS.txt b/AUTHORS.txt
@@ -130,3 +130,4 @@ Uri Gilad <antishok@gmail.com>
 Chris Faulkner <thefaulkner@gmail.com>
 Elijah Manor <elijah.manor@gmail.com>
 Daniel Chatfield <chatfielddaniel@googlemail.com>
+  
+Nikita Govorov <nikita.govorov@gmail.com>
diff --git a/src/event.js b/src/event.js
@@ -832,7 +832,7 @@ if ( !jQuery.support.changeBubbles ) {
 		teardown: function() {
 			jQuery.event.remove( this, "._change" );
-  
-			return rformElems.test( this.nodeName );
+  
+			return !rformElems.test( this.nodeName );
 		}
 	};
 }

diff --git a/test/unit/event.js b/test/unit/event.js
@@ -2985,6 +2985,29 @@ if ( hasPHP ) {
 })();
+  
+test("change handler should be detached from element", function() {
+  
+	expect( 2 );
+  
+
+  
+	var $fixture = jQuery( "<input type='text' id='change-ie-leak' />" ).appendTo( "body" );
+  
+
+  
+	var originRemoveEvent =  jQuery.removeEvent;
+  
+
+  
+	var wrapperRemoveEvent =  function(elem, type, handle){
+  
+		equal("change", type, "Event handler for 'change' event should be removed");
+  
+		equal("change-ie-leak", jQuery(elem).attr("id"), "Event handler for 'change' event should be removed from appropriate element");
+  
+		originRemoveEvent(elem, type, handle);
+  
+	};
+  
+
+  
+	jQuery.removeEvent = wrapperRemoveEvent ;
+  
+
+  
+	$fixture.bind( "change", function( event ) {});
+  
+	$fixture.unbind( "change" );
+  
+
+  
+	$fixture.remove();
+  
+
+  
+	jQuery.removeEvent = originRemoveEvent;
+  
+});
+  
+
 asyncTest("trigger click on checkbox, fires change event", function() {
 	expect(1);