New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bower.json during release, remove from repo #1673

Closed
dmethvin opened this Issue Oct 1, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@dmethvin
Member

dmethvin commented Oct 1, 2014

Since we don't commit the built file on each change, the bower.json file refers to the non-existent dist/jquery.js file. If someone tries to install from the repo as they did in gh-1671, they get confusing results. Now that we use npm for our own internal needs we could just create and commit the bower.json file at release time instead of leaving it in the repo.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 1, 2014

Member

👍

Member

mgol commented Oct 1, 2014

👍

@mgol mgol added the Feature label Oct 1, 2014

@mgol mgol added this to the 1.12.0/2.2.0 milestone Oct 1, 2014

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Oct 6, 2014

Member

Would you like me to take this?

Member

timmywil commented Oct 6, 2014

Would you like me to take this?

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Oct 6, 2014

Member

I assume this is specific to jQuery core, meaning this is an addition to our repo and not jquery-release, right?

Member

timmywil commented Oct 6, 2014

I assume this is specific to jQuery core, meaning this is an addition to our repo and not jquery-release, right?

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Oct 6, 2014

Member

Yes, and yes!

Member

dmethvin commented Oct 6, 2014

Yes, and yes!

@timmywil timmywil self-assigned this Oct 6, 2014

@mgol mgol referenced this issue Oct 19, 2014

Closed

Update bower.json #72

@timmywil timmywil added the Build label Jan 12, 2015

@timmywil timmywil modified the milestone: 3.0.0 Jan 29, 2015

@timmywil timmywil closed this in 26eca14 Jan 29, 2015

timmywil added a commit that referenced this issue Jan 29, 2015

Release: Distribute files to distribution repo
Fixes gh-1869
Fixes gh-1673
Fixes gh-2045

Conflicts:
	bower.json
	build/release.js

timmywil added a commit that referenced this issue Nov 10, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.