New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourceMappingURL comment not removed in bower build #1707

Closed
dwightjack opened this Issue Oct 15, 2014 · 5 comments

Comments

Projects
None yet
5 participants
@dwightjack

Hi,

i've installed v 1.11.1 by Bower. In the minified version there's still the sourceMappingURL comment pointing to the .map file. This conflicts with what stated in the official download page

Any hint on how to circumvent this issue or on how to contribute on this?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Oct 15, 2014

Member

This conflicts with what stated in the official download page

That was meant for CDN's distribution only. But i'm woundering if we should removed it for npm and bower releases too, or just clarify http://jquery.com/download/

@timmywil?

Member

markelog commented Oct 15, 2014

This conflicts with what stated in the official download page

That was meant for CDN's distribution only. But i'm woundering if we should removed it for npm and bower releases too, or just clarify http://jquery.com/download/

@timmywil?

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Oct 15, 2014

Member

Yea, I'm fine with removing it from bower/npm as well.

Member

timmywil commented Oct 15, 2014

Yea, I'm fine with removing it from bower/npm as well.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Oct 15, 2014

Member

But next version.

Member

timmywil commented Oct 15, 2014

But next version.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 16, 2014

Member

This was done on purpose; the idea was that people download files from CDNs but they install them from bower and copy more rarely. That might not be true any more, though, with tools like grunt-{npm,bower}copy so I'm fine with the change.

The downside will be that people not copying files around but just using what's in the npm/bower bundle will no longer see source maps.

Member

mgol commented Oct 16, 2014

This was done on purpose; the idea was that people download files from CDNs but they install them from bower and copy more rarely. That might not be true any more, though, with tools like grunt-{npm,bower}copy so I'm fine with the change.

The downside will be that people not copying files around but just using what's in the npm/bower bundle will no longer see source maps.

@mgol mgol added the Feature label Oct 16, 2014

@mgol mgol added this to the 1.12.0/2.2.0 milestone Oct 16, 2014

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Nov 26, 2014

Member

@timmywil Since you have gh-1673 which involves jquery-release can you take this one too? When can you get to this?

Member

dmethvin commented Nov 26, 2014

@timmywil Since you have gh-1673 which involves jquery-release can you take this one too? When can you get to this?

@timmywil timmywil self-assigned this Nov 26, 2014

@timmywil timmywil added the Build label Jan 30, 2015

@timmywil timmywil closed this in a76c781 Jan 30, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.