New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests work with selector-native.js #1742

Closed
mgol opened this Issue Oct 21, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@mgol
Member

mgol commented Oct 21, 2014

Originally reported by dmethvin at: http://bugs.jquery.com/ticket/13537

It would be good to have the native selector engine run a clean subset of unit tests as a sanity check. It wouldn't hurt to wait on this until we get some user feedback though.

Issue reported for jQuery 2.0b1

@mgol mgol self-assigned this Oct 21, 2014

@mgol mgol added this to the Future milestone Oct 21, 2014

@mgol mgol added the 2.x-only label Oct 21, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

I'll look into it.

Member

mgol commented Oct 21, 2014

Comment author: m_gol

I'll look into it.

@timmywil timmywil assigned timmywil and unassigned mgol Jan 30, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Jan 30, 2015

Member

I can resolve this when I get to a bug with selector-native. #2048

Member

timmywil commented Jan 30, 2015

I can resolve this when I get to a bug with selector-native. #2048

@timmywil timmywil added the Selector label Jan 30, 2015

@timmywil timmywil removed their assignment Mar 4, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 26, 2015

Member

Since we only have master now, I'm removing the master-only label, it's no longer useful.

Member

mgol commented Oct 26, 2015

Since we only have master now, I'm removing the master-only label, it's no longer useful.

@mgol mgol removed the 2.x-only label Oct 26, 2015

timmywil added a commit to timmywil/jquery that referenced this issue Nov 10, 2015

Selector: pass jQuery unit tests with selector-native
- Ignore certain tests that obviously are not supported

Fixes gh-1742
Fixes gh-2048

@timmywil timmywil self-assigned this Nov 10, 2015

@timmywil timmywil modified the milestones: 3.0.0, Future Nov 10, 2015

timmywil added a commit to timmywil/jquery that referenced this issue Nov 10, 2015

Selector: pass jQuery unit tests with selector-native
- Ignore certain tests that obviously are not supported
- Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions

Fixes gh-1742
Fixes gh-2048

@timmywil timmywil closed this in 8804644 Nov 11, 2015

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.