New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove size & andSelf methods deprecated in jQuery 1.8 #1749

Closed
mgol opened this Issue Oct 21, 2014 · 12 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Oct 21, 2014

Originally reported by m_gol at: http://bugs.jquery.com/ticket/14343

It's high time to remove jQuery.fn.size and jQuery.fn.andSelf methods. They've been deprecated since 1.8 so removing them in 2.1/1.11 seems fine.

Issue reported for jQuery 1.10.2

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

Pull request:  https://github.com/jquery/jquery/pull/1357

Member

mgol commented Oct 21, 2014

Comment author: m_gol

Pull request:  https://github.com/jquery/jquery/pull/1357

@mgol mgol self-assigned this Oct 21, 2014

@mgol mgol added this to the Future milestone Oct 21, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: dmethvin

This seems like a lot of risk for very little benefit. Those two have been deprecated for a while I suspect there is still quite a bit of usage out there. It's pretty hard to tell.

 https://github.com/search?p=2&q=andSelf+jquery&type=Code

Member

mgol commented Oct 21, 2014

Comment author: dmethvin

This seems like a lot of risk for very little benefit. Those two have been deprecated for a while I suspect there is still quite a bit of usage out there. It's pretty hard to tell.

 https://github.com/search?p=2&q=andSelf+jquery&type=Code

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

What about jQuery.fn.size? It's hard to check it due to being a more common name. On the other hand, size code is much larger than andSelf one considering the latter is just an alias to another function.

Member

mgol commented Oct 21, 2014

Comment author: m_gol

What about jQuery.fn.size? It's hard to check it due to being a more common name. On the other hand, size code is much larger than andSelf one considering the latter is just an alias to another function.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: dmethvin

Do we have any other api changes in this next release? I would rather batch these up since they can be disruptive and discourage upgrading.

Member

mgol commented Oct 21, 2014

Comment author: dmethvin

Do we have any other api changes in this next release? I would rather batch these up since they can be disruptive and discourage upgrading.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

Well, it's not officially public API but the whole jQuery.support behaves now differently, e.g. some former properties are now functions.

That's actually why I thought about 1.11/2.1 timeframe because we're changing so much with the switch to AMD etc. but maybe you're right most of these changes are internal and have little effect on our public API.

Member

mgol commented Oct 21, 2014

Comment author: m_gol

Well, it's not officially public API but the whole jQuery.support behaves now differently, e.g. some former properties are now functions.

That's actually why I thought about 1.11/2.1 timeframe because we're changing so much with the switch to AMD etc. but maybe you're right most of these changes are internal and have little effect on our public API.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: timmywil

Officially, we haven't made any changes to our public API (support is documented as changeable). Every API change is annoying to our users, even if it makes sense.

I'd say we should just keep them in. Deprecated can refer to our recommendations and doesn't have to mean removable. They are easily removable with custom builds, if so desired and they take up little space anyway.

Member

mgol commented Oct 21, 2014

Comment author: timmywil

Officially, we haven't made any changes to our public API (support is documented as changeable). Every API change is annoying to our users, even if it makes sense.

I'd say we should just keep them in. Deprecated can refer to our recommendations and doesn't have to mean removable. They are easily removable with custom builds, if so desired and they take up little space anyway.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: dmethvin

Let's hold off on this one until the following major release at least.

Member

mgol commented Oct 21, 2014

Comment author: dmethvin

Let's hold off on this one until the following major release at least.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: dmethvin

Neither of these seem all that important to me. The first step would be to get them into Migrate ASAP.

Member

mgol commented Oct 21, 2014

Comment author: dmethvin

Neither of these seem all that important to me. The first step would be to get them into Migrate ASAP.

@mgol

This comment has been minimized.

Show comment
Hide comment
Member

mgol commented Oct 21, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

Do we want to do it for 1.12/2.2?

Member

mgol commented Oct 21, 2014

Comment author: m_gol

Do we want to do it for 1.12/2.2?

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

Actually, why don't we log deprecation errors for them in Core as well? .andSelf is just an alias so we'd need a wrapper but in .size() it'd be quite easy.

Member

mgol commented Oct 21, 2014

Comment author: m_gol

Actually, why don't we log deprecation errors for them in Core as well? .andSelf is just an alias so we'd need a wrapper but in .size() it'd be quite easy.

@mgol mgol modified the milestones: 3.0.0, Future Oct 30, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 30, 2014

Member

Let's do it now!

Member

mgol commented Oct 30, 2014

Let's do it now!

mgol added a commit to mgol/jquery that referenced this issue Oct 30, 2014

mgol added a commit to mgol/jquery that referenced this issue Oct 30, 2014

mgol added a commit to mgol/jquery that referenced this issue Oct 30, 2014

@mgol mgol closed this in #1822 Oct 30, 2014

mgol added a commit that referenced this issue Oct 30, 2014

mescoda pushed a commit to mescoda/jquery that referenced this issue Nov 4, 2014

@dmethvin dmethvin added the Core label Dec 8, 2014

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.