New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests in Android 2.3, e.g. failures in appending checked radios #1785

Closed
mgol opened this Issue Oct 21, 2014 · 9 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Oct 21, 2014

Originally reported by m_gol at: http://bugs.jquery.com/ticket/15202

Currently almost all Android 2.3 failures concern appending checked radio buttons, see:  http://swarm.jquery.org/result/1992038

Fixing that should make the Android 2.3 test run almost green (there's only one other issue left)

Issue reported for jQuery 2.1.1

@mgol mgol self-assigned this Oct 21, 2014

@mgol mgol added this to the 3.0.0 milestone Oct 21, 2014

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: timmywil

m_gol, go ahead an mark your tickets open to skip triage.

Member

mgol commented Oct 21, 2014

Comment author: timmywil

m_gol, go ahead an mark your tickets open to skip triage.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 21, 2014

Member

Comment author: m_gol

Oops. On it.

Member

mgol commented Oct 21, 2014

Comment author: m_gol

Oops. On it.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jul 28, 2015

Member

It was decided we're only going to fix it on compat (if ever). Hence the compat-only label.

Member

mgol commented Jul 28, 2015

It was decided we're only going to fix it on compat (if ever). Hence the compat-only label.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 14, 2015

Member

Since this has been broken for a long time I think it might as well wait for 3.0.1.

Member

mgol commented Sep 14, 2015

Since this has been broken for a long time I think it might as well wait for 3.0.1.

@mgol mgol modified the milestones: 3.0.1, 3.0.0 Sep 14, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Oct 26, 2015

Member

Since we're not going to release the Compat line after all, I'm closing this as "Won't fix".

Member

mgol commented Oct 26, 2015

Since we're not going to release the Compat line after all, I'm closing this as "Won't fix".

@mgol mgol closed this Oct 26, 2015

@mgol mgol removed this from the 3.0.1 milestone Oct 26, 2015

@mgol mgol added the wontfix label Oct 26, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Nov 17, 2015

Member

Those failures are still on 1.12-stable & 2.2-stable so I'm reopening it with a proper milestone.

We may decide it's a wontfix but then we should perhaps disable those tests in Android 2.3 to have a clean build.

Member

mgol commented Nov 17, 2015

Those failures are still on 1.12-stable & 2.2-stable so I'm reopening it with a proper milestone.

We may decide it's a wontfix but then we should perhaps disable those tests in Android 2.3 to have a clean build.

@mgol mgol reopened this Nov 17, 2015

@mgol mgol added this to the 1.12/2.2 milestone Nov 17, 2015

@mgol mgol added the Needs review label Jan 6, 2016

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 6, 2016

Member

@jquery/core I've added the "Needs review" label since we're releasing soon and need to decide on that. I think this is wontfix at this point but we should at least blacklist those tests in Android 2.3 then to make the build pass. Thoughts?

Member

mgol commented Jan 6, 2016

@jquery/core I've added the "Needs review" label since we're releasing soon and need to decide on that. I think this is wontfix at this point but we should at least blacklist those tests in Android 2.3 then to make the build pass. Thoughts?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 6, 2016

Member

You know where i stand on this

Member

markelog commented Jan 6, 2016

You know where i stand on this

@mgol mgol self-assigned this Jan 7, 2016

@mgol mgol changed the title from Test failures in Android 2.3 in appending checked radios to Disable failing tests in Android 2.3, e.g. failures in appending checked radios Jan 7, 2016

mgol added a commit that referenced this issue Jan 7, 2016

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 7, 2016

Member

Tests have been blacklisted in 1a9c9b0 & 2732531 for 2.2-stable & in 704de81 for 1.12-stable. Closing the issue.

Member

mgol commented Jan 7, 2016

Tests have been blacklisted in 1a9c9b0 & 2732531 for 2.2-stable & in 704de81 for 1.12-stable. Closing the issue.

@mgol mgol closed this Jan 7, 2016

@mgol mgol removed the Needs review label Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.