Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Calling .empty() on a disabled callbacks object re-enables it #1790
Originally reported by TheDistantSea at: http://bugs.jquery.com/ticket/15213
Earlier today I answered this StackOverflow question, wherein this behavior is shown:
var c = $.Callbacks(); var f = /\* some function */; c.disable(); c.empty(); c.add(f); c.disabled(); // of course true c.fire(); // invokes f!
This behavior occurs in all versions of jQuery I tested (latest 1.9, 1.10, 1.11, 2.0, 2.1) -- here's a fiddle to easily reproduce it.
The problem is that .disable() relies on setting internal variables of the callbacks object to undefined, and while most other methods such as .add() test and this condition and abort if true, .empty() itself does not. Instead it resets some of those variables, which causes the abort test in the other methods to erroneously pass and ultimately for callbacks to be added to and invoked by a disabled object.
Issue reported for jQuery 1.11.1