New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event triggering a separate module #1864

Closed
dmethvin opened this Issue Nov 13, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@dmethvin
Member

dmethvin commented Nov 13, 2014

If a custom build doesn't need manually triggered events, it could save a bunch of bytes by removing jQuery.event.trigger(), jQuery.event.simulate(), jQuery.fn.trigger(), and jQuery.fn.triggerHandler(). This would mostly be useful for the 2.x (now 3.x-master) branch because the 1.x (3.x-compat) branch relies pretty heavily on manually triggered events to fix up IE8. On master, manual triggering is used to create bubbling focusin/out events and fire ajax events, but there are other approaches devs can use for both situations.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 14, 2015

Member

@timmywil @dmethvin Moving to 3.1.0 as it won't be a breaking change and so doesn't have to go in 3.0.0. Revert the change if you disagree.

Member

mgol commented Sep 14, 2015

@timmywil @dmethvin Moving to 3.1.0 as it won't be a breaking change and so doesn't have to go in 3.0.0. Revert the change if you disagree.

@mgol mgol modified the milestones: 3.1.0, 3.0.0 Sep 14, 2015

dmethvin added a commit to dmethvin/jquery that referenced this issue Nov 5, 2015

Event: Separate trigger/simulate into its own module
Fixes gh-1864

This also pulls the focusin/out special event into its own module, since that
depends on simulate(). NB: The ajax module triggers events pretty heavily.
@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Nov 5, 2015

Member

@timmywil I can grab this if you want. Didn't notice you were assigned!

Member

dmethvin commented Nov 5, 2015

@timmywil I can grab this if you want. Didn't notice you were assigned!

@timmywil timmywil assigned dmethvin and unassigned timmywil Nov 5, 2015

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Nov 5, 2015

Member

@dmethvin Feel free!

Member

timmywil commented Nov 5, 2015

@dmethvin Feel free!

@dmethvin dmethvin closed this in c9935b6 Nov 6, 2015

@timmywil timmywil modified the milestones: 3.0.0, 3.1.0 Jan 8, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.