New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: zip files are empty #1940

Closed
dmethvin opened this Issue Dec 17, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@dmethvin
Member

dmethvin commented Dec 17, 2014

The release script is supposed to build two zip files that we distribute to the CDNs. They are created but always zero-length.

googlecdn-jquery-VERSION.zip should have the release files (.js, .min.js, and .min.map) named without version numbers and internally consistent (e.g., the map should reference the file without version number). This file is also distributed to cdnjs.

mscdn-jquery-VERSION.zip should have the release files with version numbers.

@dmethvin dmethvin added this to the 3.0.0 milestone Dec 17, 2014

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Dec 17, 2014

Member

Better to have the test runs create these zip files than skip it:

https://github.com/jquery/jquery/blob/1.11-stable/build/release.js#L81-84

Member

dmethvin commented Dec 17, 2014

Better to have the test runs create these zip files than skip it:

https://github.com/jquery/jquery/blob/1.11-stable/build/release.js#L81-84

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Dec 17, 2014

Member

Looking at that code, they are created for test runs. They're not created for pre-releases.

Member

scottgonzalez commented Dec 17, 2014

Looking at that code, they are created for test runs. They're not created for pre-releases.

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Dec 17, 2014

Member

Oh right, I was confusing the meaning of the variable.

Member

dmethvin commented Dec 17, 2014

Oh right, I was confusing the meaning of the variable.

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Dec 17, 2014

Member

This is the final step in the build, maybe the archive creation in happening async and we're not waiting on it before exiting.

Member

dmethvin commented Dec 17, 2014

This is the final step in the build, maybe the archive creation in happening async and we're not waiting on it before exiting.

@timmywil timmywil added the Build label Jan 12, 2015

@timmywil timmywil modified the milestone: 3.0.0 Jan 29, 2015

@timmywil timmywil closed this in e0673df Jan 30, 2015

timmywil added a commit that referenced this issue Jan 30, 2015

timmywil added a commit that referenced this issue Nov 10, 2015

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.