New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume the browser environment in src/, run a smoke-test on Node #1950

Closed
mgol opened this Issue Dec 18, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@mgol
Member

mgol commented Dec 18, 2014

Since we want to support Node.js on the master branch, we cannot rely on globals except window (that is passed to the factory) and setTimeout/clearTimeout/setInterval/clearInterval.

jsHint config should be updated and we should have basic Node smoke-testing so that issues like #1788 don't happen in the future.

mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014

@mgol mgol added the Build label Dec 18, 2014

@mgol mgol added this to the 3.0.0 milestone Dec 18, 2014

@mgol mgol self-assigned this Dec 18, 2014

mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014

mgol added a commit to mgol/jquery that referenced this issue Dec 18, 2014

mgol added a commit to mgol/jquery that referenced this issue Dec 26, 2014

@mgol mgol closed this in 76df9e4 Dec 26, 2014

mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015

mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015

mgol added a commit to mgol/jquery that referenced this issue Jul 28, 2015

mgol added a commit to mgol/jquery that referenced this issue Aug 16, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 6, 2016

Member

This has been backported to 1.12.0 & 2.2.0 so I changed the milestone (it used to say 3.0.0).

Member

mgol commented Mar 6, 2016

This has been backported to 1.12.0 & 2.2.0 so I changed the milestone (it used to say 3.0.0).

@mgol mgol modified the milestones: 1.12.0/2.2.0, 3.0.0 Mar 6, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.