Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Core: Issue while creating dash-delimited nodes #1987
JQuery fails in some cases to create dash-delimited notes:
// Works fine and creates the element: $('<div-d></div-d>'); // Does not create the element: $('<tr-d></tr-d>'); // ... and it should, since document.createElement works fine too: document.createElement('tr-d');
Reported first here: angular/angular.js#10617
So we would be on same page here:
Characters that could be used in tag name of custom elements are described in xml specification. Like
But this discussion could be deferred and i let @dmethvin answer that.
Apart from that, this looks like real use-case and real bug, there is two problems with this particular case: first with
Your commit, mentioned in this ticket, would resolve
This is why even
Would you like to send us PR for both?
Thanks for the instructions, and yes, I'd like to submit a PR for it.
Just to be clear and fair, issue was initially reported and patched by @gkalpak on Angular.js repo. It just happened that I bumped into it at the same time and tried to share the load.
@LeonardoBraga: I am glad you are sharing the load (since I am not familiar with jQuery's contributing conventions
(Seems like a whole lot of people are involved into this one-character addition