New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The data-URI append(<script>) test is flakey #1993

Closed
mgol opened this Issue Jan 5, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Jan 5, 2015

The test sometimes fails on iOS/Opera; I'll attach a link next time I see it.

@mgol mgol added this to the 3.0.0 milestone Jan 5, 2015

@mgol mgol added the Manipulation label Jan 5, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
Member

mgol commented Jan 12, 2015

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 12, 2015

Member

Safari 7 seems to fail it a lot: http://swarm.jquery.org/project/jquery

Member

mgol commented Jan 12, 2015

Safari 7 seems to fail it a lot: http://swarm.jquery.org/project/jquery

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 14, 2015

Member

Can't seems to repo it, could you try? If you will have the same fate, i propose to fly blind and increase the timeout.

Member

markelog commented Jan 14, 2015

Can't seems to repo it, could you try? If you will have the same fate, i propose to fly blind and increase the timeout.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Jan 14, 2015

Member

I can't reproduce it locally, it happens from time to time on TestSwarm so it seems to require an enough large sample (but enough for us to hit it since we test so much).

We can try increasing the timeout and see what happens. I don't like when we cannot control the test fully. :(

Member

mgol commented Jan 14, 2015

I can't reproduce it locally, it happens from time to time on TestSwarm so it seems to require an enough large sample (but enough for us to hit it since we test so much).

We can try increasing the timeout and see what happens. I don't like when we cannot control the test fully. :(

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 14, 2015

Member

I don't like when we cannot control the test fully. :(

Yeah

/cc @dmethvin

Member

markelog commented Jan 14, 2015

I don't like when we cannot control the test fully. :(

Yeah

/cc @dmethvin

markelog added a commit that referenced this issue Jan 15, 2015

Manipulation: increase delay of data-URI test
For Safar7/Opera - shot in the dark, can't reproduce this locally

Ref gh-1993
@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 15, 2015

Member

Commited only in the compat at the moment, not gonna close this until fix will be verified.

Member

markelog commented Jan 15, 2015

Commited only in the compat at the moment, not gonna close this until fix will be verified.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 26, 2015

Member

It seems timeout increase did help, committing to master

Member

markelog commented Jan 26, 2015

It seems timeout increase did help, committing to master

@markelog markelog closed this in 4fae911 Jan 26, 2015

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.