New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of manipulation wrappers #2002

Closed
markelog opened this Issue Jan 11, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@markelog
Member

markelog commented Jan 11, 2015

Talking about those.

We can remove most of the wrappers for col element (effectively removing it entirely) from master and compat and remove area and legend wrappers, since they was needed for IE6-7 only.

PR tomorrow.

@markelog markelog self-assigned this Jan 11, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Jan 11, 2015

Member

Would definitely like to see this in 3.0 if it can be done.

Member

dmethvin commented Jan 11, 2015

Would definitely like to see this in 3.0 if it can be done.

markelog added a commit to markelog/jquery that referenced this issue Jan 26, 2015

Manipulation: simplification of manipulation wrappers
Since support for IE6-7 was dropped these wrappers no longer required
Ref 90d7cc1
Fixes #2002

markelog added a commit to markelog/jquery that referenced this issue Jan 26, 2015

Manipulation: simplification of manipulation wrappers
Since support for IE6-7 was dropped these wrappers no longer required
Ref 90d7cc1
Fixes gh-2002

markelog added a commit that referenced this issue Feb 10, 2015

Manipulation: simplification of manipulation wrappers
Since support for IE6-7 was dropped these wrappers no longer required

Ref 90d7cc1
Ref gh-2002
Closes gh-2032

markelog added a commit that referenced this issue Feb 10, 2015

Manipulation: simplification of manipulation wrappers
Since support for IE6-7 was dropped these wrappers no longer required

Ref 90d7cc1
Ref gh-2002
Closes gh-2032

markelog added a commit that referenced this issue Feb 10, 2015

Manipulation: simplify html wrappers
Take advantage of html serialization for html wrappers - saves 26 bytes
Plus add additional test for "col" element

(cherry-picked from 0ea342a)

Closes gh-2031
Fixes gh-2002

@markelog markelog closed this in 0ea342a Feb 10, 2015

anthonyryan1 added a commit to anthonyryan1/jquery that referenced this issue Jul 25, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intenitonally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

Reverts 0ea342a
See also gh-2031, gh-2002
Closes gh-2493

anthonyryan1 added a commit to anthonyryan1/jquery that referenced this issue Jul 25, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intentionally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

Reverts 0ea342a
See also gh-2031, gh-2002
Closes gh-2493

anthonyryan1 added a commit to anthonyryan1/jquery that referenced this issue Sep 9, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intentionally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

Reverts 0ea342a
See also gh-2031, gh-2002
Closes gh-2493

anthonyryan1 added a commit to anthonyryan1/jquery that referenced this issue Sep 9, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intentionally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

Reverts 0ea342a
See also gh-2031, gh-2002
Closes gh-2493

mgol added a commit that referenced this issue Sep 14, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intentionally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

Reverts 0ea342a

Refs gh-2031
Refs gh-2002
Fixes gh-2493
Closes gh-2499

mgol added a commit that referenced this issue Sep 14, 2015

Manipulation: Don't provide the parser with sloppy table markup
While we can reply on parsers that were designed to cope with
malformed syntax to understand what we mean, we shouldn't
intentionally provide bad markup, not all parsers will accept
it.

"Be conservative in what you do, be liberal in what you accept
from others."

(cherry-picked from 99e8ff1)

Reverts 0ea342a

Refs gh-2031
Refs gh-2002
Fixes gh-2493
Closes gh-2499

markelog added a commit that referenced this issue Nov 10, 2015

Manipulation: simplify html wrappers
Take advantage of html serialization for html wrappers - saves 26 bytes
Plus add additional test for "col" element

Closes gh-2031
Fixes gh-2002

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.