New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tag name related regexes #2005

Closed
markelog opened this Issue Jan 13, 2015 · 7 comments

Comments

Projects
None yet
6 participants
@markelog
Member

markelog commented Jan 13, 2015

See discussion in related pull, specifically @gibson042 comment.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jan 13, 2015

Member

@LeonardoBraga interested in providing fix for it?

Member

markelog commented Jan 13, 2015

@LeonardoBraga interested in providing fix for it?

@LeonardoBraga

This comment has been minimized.

Show comment
Hide comment
@LeonardoBraga

LeonardoBraga Jan 13, 2015

Contributor

@Marklog - Yes, definitely. Will work on the PR ASAP.

Contributor

LeonardoBraga commented Jan 13, 2015

@Marklog - Yes, definitely. Will work on the PR ASAP.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Sep 15, 2015

Member

@LeonardoBraga Still interested?

Member

mgol commented Sep 15, 2015

@LeonardoBraga Still interested?

@LeonardoBraga

This comment has been minimized.

Show comment
Hide comment
@LeonardoBraga

LeonardoBraga Sep 15, 2015

Contributor

@mzgol Sure. I'll work on it over the weekend and send the PR. Thanks.

Contributor

LeonardoBraga commented Sep 15, 2015

@mzgol Sure. I'll work on it over the weekend and send the PR. Thanks.

@mgol mgol modified the milestones: 3.0.1, 3.0.0 Sep 16, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Oct 1, 2015

Member

@LeonardoBraga just pinging to see if you're going to send a PR. We'd love to have your contribution!

Member

dmethvin commented Oct 1, 2015

@LeonardoBraga just pinging to see if you're going to send a PR. We'd love to have your contribution!

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 7, 2015

@LeonardoBraga

This comment has been minimized.

Show comment
Hide comment
@LeonardoBraga

LeonardoBraga Oct 8, 2015

Contributor

@dmethvin I'm sorry for the delay on sending the PR. Should I also apply the same changes to any other branches and send additional PRs?

Contributor

LeonardoBraga commented Oct 8, 2015

@dmethvin I'm sorry for the delay on sending the PR. Should I also apply the same changes to any other branches and send additional PRs?

@gibson042

This comment has been minimized.

Show comment
Hide comment
@gibson042

gibson042 Oct 8, 2015

Member

No need; this is easy to cherry pick.

Member

gibson042 commented Oct 8, 2015

No need; this is easy to cherry pick.

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 13, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 14, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 14, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Oct 20, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Dec 5, 2015

LeonardoBraga added a commit to LeonardoBraga/jquery that referenced this issue Dec 5, 2015

@gibson042 gibson042 closed this in fb9472c Jan 7, 2016

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.