Simplification of native method signatures #2047

Closed
markelog opened this Issue Jan 29, 2015 · 1 comment

Comments

Projects
None yet
4 participants
@markelog
Member

markelog commented Jan 29, 2015

Prime candidates, at the moment, are addEventListener third argument for master branch and second argument of getComputedStyle for both branches.

See #1842 (comment)

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Feb 4, 2015

Member

addEventListener third argument for master

Why just master? The only difference between branches is IE8 which obviously doesn't go through the addEventListener path.

Member

mgol commented Feb 4, 2015

addEventListener third argument for master

Why just master? The only difference between branches is IE8 which obviously doesn't go through the addEventListener path.

@mgol mgol added this to the 3.0.0 milestone Feb 4, 2015

@markelog markelog self-assigned this Mar 8, 2015

markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref #2047

markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015

Event: remove extensive checks for "originalEvent" property
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref #2047

markelog added a commit to markelog/jquery that referenced this issue Mar 8, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref #2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Event: remove extensive checks for "originalEvent" property
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref #2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Event: remove extensive checks for "originalEvent" property
Support for native methods of the affected code-paths exist in supported
browsers, nevertheless, those are risky changes.

Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 2, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Closes gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 3, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015

markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015

Ajax: remove "onunload" event handler
Update for IE9 which fixes the issue was released November 12, 2013
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047

markelog added a commit to markelog/jquery that referenced this issue Apr 28, 2015

markelog added a commit that referenced this issue May 3, 2015

Event: add support comment
(cherry-picked from 9db9316)

Ref gh-2047

markelog added a commit that referenced this issue May 3, 2015

Ajax: remove "onunload" event handler
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047
Ref a117dd0

markelog added a commit that referenced this issue May 3, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047
Ref 85577a3

markelog added a commit that referenced this issue May 3, 2015

markelog added a commit that referenced this issue May 3, 2015

Ajax: remove "onunload" event handler
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047

markelog added a commit that referenced this issue May 3, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047

@markelog markelog closed this in a873558 May 3, 2015

markelog added a commit that referenced this issue Nov 10, 2015

markelog added a commit that referenced this issue Nov 10, 2015

Ajax: remove "onunload" event handler
Remove hack for IE lost connections, update for it was released
by Microsoft at November 12, 2013.
See https://support.microsoft.com/en-us/kb/2905733

Ref trac-5280
Ref gh-2047

markelog added a commit that referenced this issue Nov 10, 2015

Core:CSS:Event: simplification of native method signatures
* Remove third argument from "addEventListener"

* Remove third argument from "removeEventListener"

* Remove second argument from "getComputedStyle"

Ref gh-2047

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.