Don't expose jQuery.swap #2058

Closed
mgol opened this Issue Feb 3, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@mgol
Member

mgol commented Feb 3, 2015

Even if we want/need jQuery.swap internally, we still shouldn't expose it, there is no reason to do it now that we have a robust modular architecture. The method is undocumented so technically we could stop exposing it whenever we want; no better moment to do it than the 3.0 release!

I didn't see it in the code but just to make sure: @scottgonzalez & @arschmitz, I assume UI/Mobile doesn't depend on it?

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Feb 3, 2015

Member

We definitely don't use it in UI.

Member

scottgonzalez commented Feb 3, 2015

We definitely don't use it in UI.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Feb 3, 2015

Member

I didn't even know it existed until i saw the related discussion. It's definitely not in mobile either.

Member

arschmitz commented Feb 3, 2015

I didn't even know it existed until i saw the related discussion. It's definitely not in mobile either.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Feb 3, 2015

Member

Sounds good to me! I think it was originally exposed so users could have control over when to retrieve useful values for hidden elements, but that use case is rare at best.

Member

timmywil commented Feb 3, 2015

Sounds good to me! I think it was originally exposed so users could have control over when to retrieve useful values for hidden elements, but that use case is rare at best.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Feb 3, 2015

Member

OK then, assigning to myself!

Member

mgol commented Feb 3, 2015

OK then, assigning to myself!

@mgol mgol self-assigned this Feb 3, 2015

@mgol mgol added this to the 3.0.0 milestone Feb 3, 2015

@mgol mgol added the CSS label Feb 3, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Feb 3, 2015

Member

If it turns out something needs it but we don't want it internally, we could put it in jQuery Migrate. I doubt it's used externally and we never documented it, plus it's really bad practice from a performance standpoint.

Member

dmethvin commented Feb 3, 2015

If it turns out something needs it but we don't want it internally, we could put it in jQuery Migrate. I doubt it's used externally and we never documented it, plus it's really bad practice from a performance standpoint.

mgol added a commit to mgol/jquery that referenced this issue Mar 30, 2015

CSS: Don't expose jQuery.swap
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes gh-2058
Closes gh-2182

@mgol mgol closed this in bb4d888 Apr 13, 2015

mgol added a commit that referenced this issue Apr 13, 2015

CSS: Don't expose jQuery.swap
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes gh-2058
Closes gh-2182

mgol added a commit that referenced this issue Nov 10, 2015

CSS: Don't expose jQuery.swap
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes gh-2058
Closes gh-2182

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@dejvo dejvo referenced this issue in angular-ui/ui-grid Jun 30, 2016

Merged

Compatibility with jQuery 2.1.4 and above #5506

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.