New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ownerDocument check in offset getter #2115

Closed
gibson042 opened this Issue Mar 2, 2015 · 2 comments

Comments

Projects
None yet
4 participants
@gibson042
Member

gibson042 commented Mar 2, 2015

Fallout from #2043: https://github.com/jquery/jquery/pull/2043/files#r23981494

Since all supported browsers have getBoundingClientRect, there's no reason not to just call the method right away, letting an exception throw if input is in fact not a DOM element.

The "object without getBoundingClientRect" test will have to go as well.

@gibson042 gibson042 added this to the 3.0.0 milestone Mar 2, 2015

@gibson042 gibson042 changed the title from Remove document check in offset getter to Remove ownerDocument check in offset getter Mar 2, 2015

@dmethvin

This comment has been minimized.

Show comment
Hide comment
@dmethvin

dmethvin Mar 3, 2015

Member

According to #12536 we had that guard in for browsers we no longer support, so that sounds good to me.

Member

dmethvin commented Mar 3, 2015

According to #12536 we had that guard in for browsers we no longer support, so that sounds good to me.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Apr 26, 2015

Member

Yes, we already have a couple of places where we stopped guarding against browsers with missing getBoundingClientRect so this one should go as well.

Member

mgol commented Apr 26, 2015

Yes, we already have a couple of places where we stopped guarding against browsers with missing getBoundingClientRect so this one should go as well.

@timmywil timmywil removed the Needs review label Apr 27, 2015

@timmywil timmywil self-assigned this May 5, 2015

@timmywil timmywil closed this in 6176567 May 5, 2015

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.