New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom & drop obsolete workarounds #2153

Closed
mgol opened this Issue Mar 20, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Mar 20, 2015

We currently test on jsdom 1.5.x. The latest version supporting Node.js is 3.1.2, we should test on that. For example, in jsdom 3.1.2 a document created via document.implementation.createHTMLDocument( "" ) has a body.

mgol added a commit to mgol/jquery that referenced this issue Mar 20, 2015

Core: Update tested jsdom, drop obsolete workarounds
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes gh-2153
Closes gh-2154

@mgol mgol self-assigned this Mar 20, 2015

@mgol mgol added the Core label Mar 20, 2015

@mgol mgol added this to the 3.0.0 milestone Mar 20, 2015

mgol added a commit to mgol/jquery that referenced this issue Mar 25, 2015

Core: Update tested jsdom, drop obsolete workarounds
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes gh-2153
Closes gh-2154

mgol added a commit that referenced this issue Mar 25, 2015

Core: Update tested jsdom, drop obsolete workarounds
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

(partially cherry-picked from 95c0a10)

Fixes gh-2153
Closes gh-2154

mgol added a commit to mgol/jquery that referenced this issue Mar 30, 2015

Core: Update tested jsdom, drop obsolete workarounds
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes gh-2153
Closes gh-2154

@mgol mgol closed this in #2154 Mar 30, 2015

mgol added a commit that referenced this issue Nov 10, 2015

Core: Update tested jsdom, drop obsolete workarounds
The latest version supporting Node.js is 3.1.2; some workarounds are not needed
for this version. For example, in jsdom 3.1.2 a document created via
document.implementation.createHTMLDocument( "" ) has a body.

Fixes gh-2153
Closes gh-2154

@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016

@cssmagic cssmagic referenced this issue May 18, 2016

Open

jQuery #5

@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.