`grunt npmcopy` is not a noop on master #2160

Closed
mgol opened this Issue Mar 24, 2015 · 7 comments

Comments

Projects
None yet
4 participants
@mgol
Member

mgol commented Mar 24, 2015

grunt npmcopy on master modifies Sinon fake timers heavily. Perhaps the npmcopy task wasn't run after one of recent Sinon updates?

@mgol mgol added the Build label Mar 24, 2015

@mgol mgol added this to the 3.0.0 milestone Mar 24, 2015

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
Member

scottgonzalez commented Mar 24, 2015

See 9101704.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 24, 2015

Member

@scottgonzalez Thanks. Maybe having grunt npmcopy as a postinstall script wouldn't be bad. I've heard postinstall scripts are discouraged although I don't know why.

Member

mgol commented Mar 24, 2015

@scottgonzalez Thanks. Maybe having grunt npmcopy as a postinstall script wouldn't be bad. I've heard postinstall scripts are discouraged although I don't know why.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Mar 24, 2015

Member

That would potentially put you in a dirty state immediately though, right? That doesn't sound great.

Member

scottgonzalez commented Mar 24, 2015

That would potentially put you in a dirty state immediately though, right? That doesn't sound great.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 24, 2015

Member

If you touch package.json, it's good that it gets you in a dirty state so that you don't forget to commit everything. If files match, this will be a noop.

Member

mgol commented Mar 24, 2015

If you touch package.json, it's good that it gets you in a dirty state so that you don't forget to commit everything. If files match, this will be a noop.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Mar 24, 2015

Member

Assuming the person making the change is manually changing package.json and then using npm install. If the changes are made with npm install --save-dev some-package, then the postinstall script won't run.

Member

scottgonzalez commented Mar 24, 2015

Assuming the person making the change is manually changing package.json and then using npm install. If the changes are made with npm install --save-dev some-package, then the postinstall script won't run.

@timmywil

This comment has been minimized.

Show comment
Hide comment
@timmywil

timmywil Mar 24, 2015

Member

A postinstall would help us remember, but we don't want users and one-time contributors to have to deal with it.

Member

timmywil commented Mar 24, 2015

A postinstall would help us remember, but we don't want users and one-time contributors to have to deal with it.

@mgol

This comment has been minimized.

Show comment
Hide comment
@mgol

mgol Mar 24, 2015

Member

If the changes are made with npm install --save-dev some-package, then the postinstall script won't run.

Right. :/ Not a good idea then.

Member

mgol commented Mar 24, 2015

If the changes are made with npm install --save-dev some-package, then the postinstall script won't run.

Right. :/ Not a good idea then.

@timmywil timmywil closed this in 98c25b7 Mar 24, 2015

timmywil added a commit that referenced this issue Nov 10, 2015

@dmethvin dmethvin removed this from the 3.0.0 milestone Jan 7, 2016

@cssmagic cssmagic referenced this issue in cssmagic/ChangeLog May 18, 2016

Open

jQuery #5

@jquery jquery locked as resolved and limited conversation to collaborators Jun 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.